Skip to content

Suggest box/pin/arc ing receiver on method calls #83667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2021
Merged

Suggest box/pin/arc ing receiver on method calls #83667

merged 2 commits into from
Mar 30, 2021

Conversation

@estebank
Copy link
Contributor

@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Hide unnecessary reference to trait
0195f8d 
When the problem for a method not being found in its receiver is due to
arbitrary self-types, we don't want to mention importing or implementing
the trait, instead we suggest wrapping.
@estebank estebank force-pushed the cool-bears-hot-tip branch from 27260f2 to 0195f8d Compare March 30, 2021 03:49
@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 30, 2021

📌 Commit 0195f8d has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2021
@bors
Auto merge of rust-lang#83674 - Dylan-DPC:rollup-bcuc1hl, r=Dylan-DPC
16156fb 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#83568 (update comment at MaybeUninit::uninit_array)
 - rust-lang#83571 (Constantify some slice methods)
 - rust-lang#83579 (Improve pointer arithmetic docs)
 - rust-lang#83645 (Wrap non-pre code blocks)
 - rust-lang#83656 (Add a regression test for issue-82865)
 - rust-lang#83662 (Update books)
 - rust-lang#83667 (Suggest box/pin/arc ing receiver on method calls)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b46778 into rust-lang:master Mar 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 30, 2021
@ghost ghost mentioned this pull request Apr 17, 2021
Closed
@estebank estebank mentioned this pull request Apr 24, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 25, 2021
@Dylan-DPC
Rollup merge of rust-lang#84499 - estebank:issue-84272, r=jackh726
d1e2564 
Tweak trait not `use`d suggestion

Fix rust-lang#84272. Follow up to rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 25, 2021
@Dylan-DPC
Rollup merge of rust-lang#84499 - estebank:issue-84272, r=jackh726
272c7d3 
Tweak trait not `use`d suggestion

Fix rust-lang#84272. Follow up to rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 25, 2021
@Dylan-DPC
Rollup merge of rust-lang#84499 - estebank:issue-84272, r=jackh726
5aca6da 
Tweak trait not `use`d suggestion

Fix rust-lang#84272. Follow up to rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 25, 2021
@Dylan-DPC
Rollup merge of rust-lang#84499 - estebank:issue-84272, r=jackh726
ae316d6 
Tweak trait not `use`d suggestion

Fix rust-lang#84272. Follow up to rust-lang#83667.
estebank added a commit to estebank/rust that referenced this pull request May 2, 2021
@estebank
Account for unsatisfied bounds in E0599
1e89b58 
Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@estebank estebank mentioned this pull request May 2, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
eb5ee09 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
337899c 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
5bfedb4 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
7ac6a01 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
df55085 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
19d0843 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
RalfJung added a commit to RalfJung/rust that referenced this pull request May 5, 2021
@RalfJung
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
92d368b 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
RalfJung added a commit to RalfJung/rust that referenced this pull request May 5, 2021
@RalfJung
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
7f7fe25 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 5, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
bdc7168 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
RalfJung added a commit to RalfJung/rust that referenced this pull request May 5, 2021
@RalfJung
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
db77072 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
workingjubilee pushed a commit to workingjubilee/rustc that referenced this pull request May 6, 2021
@estebank @workingjubilee
Account for unsatisfied bounds in E0599
38bc797 
Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this pull request May 6, 2021
@estebank @Mark-Simulacrum
Account for unsatisfied bounds in E0599
8c48c6e 
Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

6 participants

@estebank @rust-highfive @rust-log-analyzer @lcnr @bors @rustbot