Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for if (let pat = expr) {} #82854

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Account for if (let pat = expr) {} #82854

merged 4 commits into from
Mar 9, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Mar 7, 2021 •
edited
Loading

Fix #82827.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2021
@estebank estebank mentioned this pull request Mar 7, 2021
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
henryboisdequin
henryboisdequin suggested changes Mar 7, 2021
View reviewed changes
Copy link
Contributor

@henryboisdequin henryboisdequin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(deleted)

@oli-obk
Copy link
Contributor

oli-obk commented Mar 8, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 8, 2021

📌 Commit aa7ac6e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2021
@m-ou-se m-ou-se mentioned this pull request Mar 8, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2021
@bors
Auto merge of rust-lang#82911 - m-ou-se:rollup-rjomgja, r=m-ou-se
bb3afe1 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#82711 (Add documentation for string->Cow conversions)
 - rust-lang#82767 (Update minifier dependency version)
 - rust-lang#82800 (Move rustdoc UI tests into a subdirectory)
 - rust-lang#82810 (Typo fix in Unstable book: `cargo cov` -> `cargo profdata`)
 - rust-lang#82829 (Handle negative literals in cast overflow warning)
 - rust-lang#82854 (Account for `if (let pat = expr) {}`)
 - rust-lang#82870 (Add note about the `#[doc(no-inline)]` usage)
 - rust-lang#82874 (Add codegen tests for some issues closed by LLVM 12)
 - rust-lang#82881 (diagnostics: Be clear about "crate root" and `::foo` paths in resolve diagnostics)
 - rust-lang#82888 (Grammar Fixes)
 - rust-lang#82897 ([.mailmap] Add entry for Ramkumar Ramachandra)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6a55aa1 into rust-lang:master Mar 9, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 9, 2021
@ehuss ehuss mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryboisdequin henryboisdequin henryboisdequin requested changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Misplaced parenthesis in if let produces unhelpful error message
7 participants
@estebank @rust-highfive @rust-log-analyzer @oli-obk @bors @henryboisdequin @rustbot