Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement built-in attribute macro #[cfg_eval] + some refactoring #82682

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Implement built-in attribute macro #[cfg_eval] + some refactoring #82682

merged 5 commits into from
Mar 8, 2021

Commits on Mar 6, 2021

  1. rustc_ast: Replace AstLike::finalize_tokens with a getter tokens_mut

    @petrochenkov
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    069e612 View commit details
    Browse the repository at this point in the history

  2. Implement built-in attribute macro #[cfg_eval]

    @petrochenkov
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    5dad6c2 View commit details
    Browse the repository at this point in the history

  3. Move full configuration logic from rustc_expand to `rustc_builtin_m… 

    …acros`

This logic is applicable to two specific macros and not to the expansion infrastructure in general.
    @petrochenkov
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    f9019b7 View commit details
    Browse the repository at this point in the history

  4. cfg_eval: Configure everything through mutable visitor methods 

    This is simpler and mirrors what invocation collector does
    @petrochenkov
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    10ed08f View commit details
    Browse the repository at this point in the history

  5. rustc_builtin_macros: Share some more logic between derive and `cfg… 

    …_eval`
    @petrochenkov
    petrochenkov committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    5d27728 View commit details
    Browse the repository at this point in the history