Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PpMode and friends #82269

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented Feb 18, 2021

This PR:

  • Separates PpSourceMode and PpHirMode to remove invalid states
  • Renames the variant to remove the redundant Ppm prefix
  • Adds basic documentation for the different pretty-print modes
  • Cleanups some code to make it more idiomatic

Not sure if this is actually useful, but it looks cleaner to me.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2021
@LeSeulArtichaut
Copy link
Contributor Author

Mhh, maybe r? @jyn514 ?

@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member

jyn514 commented Feb 18, 2021

I'm not the right reviewer.

r? @pnkfelix maybe?

@rust-highfive rust-highfive assigned pnkfelix and unassigned jyn514 Feb 18, 2021
@LeSeulArtichaut LeSeulArtichaut force-pushed the cleanup-ppmode branch 2 times, most recently from 013a4a9 to bd21532 Compare February 18, 2021 20:15
@rust-log-analyzer

This comment has been minimized.

@LeSeulArtichaut LeSeulArtichaut added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-pretty Area: Pretty printing (including `-Z unpretty`) labels Feb 19, 2021
@rust-log-analyzer

This comment has been minimized.

@spastorino
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Feb 23, 2021

📌 Commit dd3772e has been approved by spastorino

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
…pastorino

Cleanup `PpMode` and friends

This PR:
 - Separates `PpSourceMode` and `PpHirMode` to remove invalid states
 - Renames the variant to remove the redundant `Ppm` prefix
 - Adds basic documentation for the different pretty-print modes
 - Cleanups some code to make it more idiomatic

Not sure if this is actually useful, but it looks cleaner to me.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
…pastorino

Cleanup `PpMode` and friends

This PR:
 - Separates `PpSourceMode` and `PpHirMode` to remove invalid states
 - Renames the variant to remove the redundant `Ppm` prefix
 - Adds basic documentation for the different pretty-print modes
 - Cleanups some code to make it more idiomatic

Not sure if this is actually useful, but it looks cleaner to me.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 24, 2021
…pastorino

Cleanup `PpMode` and friends

This PR:
 - Separates `PpSourceMode` and `PpHirMode` to remove invalid states
 - Renames the variant to remove the redundant `Ppm` prefix
 - Adds basic documentation for the different pretty-print modes
 - Cleanups some code to make it more idiomatic

Not sure if this is actually useful, but it looks cleaner to me.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
…pastorino

Cleanup `PpMode` and friends

This PR:
 - Separates `PpSourceMode` and `PpHirMode` to remove invalid states
 - Renames the variant to remove the redundant `Ppm` prefix
 - Adds basic documentation for the different pretty-print modes
 - Cleanups some code to make it more idiomatic

Not sure if this is actually useful, but it looks cleaner to me.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2021
Rollup of 11 pull requests

Successful merges:

 - rust-lang#82269 (Cleanup `PpMode` and friends)
 - rust-lang#82431 (Set RUST_BACKTRACE=0 when running `treat-err-as-bug` tests)
 - rust-lang#82441 (Fix typo in sanitizer flag in unstable book.)
 - rust-lang#82463 (panic_bounds_checks should be panic_bounds_check)
 - rust-lang#82464 (Update outdated comment in unix Command.)
 - rust-lang#82467 (library: Normalize safety-for-unsafe-block comments)
 - rust-lang#82468 (Move pick_by_value_method docs above function header)
 - rust-lang#82484 (rustdoc: Remove duplicate "List of all items")
 - rust-lang#82502 (Only look for HTML `tidy` when running rustdoc tests)
 - rust-lang#82503 (fix typo in `pre-commit.sh`)
 - rust-lang#82510 (Fix typo in `param_env_reveal_all_normalized`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8c0119d into rust-lang:master Feb 26, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 26, 2021
@LeSeulArtichaut LeSeulArtichaut deleted the cleanup-ppmode branch February 26, 2021 09:32
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 4, 2021
…storino

Add `-Z unpretty` flags for the AST

Implements rust-lang/compiler-team#408.
Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269.
cc rust-lang/rustc-dev-guide#1062
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2021
…orino

Add `-Z unpretty` flags for the AST

Implements rust-lang/compiler-team#408.
Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269.
cc rust-lang/rustc-dev-guide#1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants