Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder lifetime error cleanup #81972

Merged
merged 7 commits into from
Feb 18, 2021
Merged

Placeholder lifetime error cleanup #81972

merged 7 commits into from
Feb 18, 2021

Commits on Feb 9, 2021

  1. Use longer lifetime in try_report_from_nll return type

    @matthewjasper
    matthewjasper committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    1eb79f3 View commit details
    Browse the repository at this point in the history

  2. Using tracing macros in placeholder_error.rs

    @matthewjasper
    matthewjasper committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    638980a View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary note on errors 

    Seeing the trait definition doesn't help with implementation not general
enough errors, so don't make the error message larger to show it.
    @matthewjasper
    matthewjasper committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c2066cf View commit details
    Browse the repository at this point in the history

  4. Avoid repeating self type in placeholder error

    @matthewjasper
    matthewjasper committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    daab6db View commit details
    Browse the repository at this point in the history

  5. Report "nice" placeholder errors more often 

    If we have a cause containing `ValuePairs::PolyTraitRefs` but neither
TraitRef has any escaping bound regions then we report the same error as
for `ValuePairs::TraitRefs`.
    @matthewjasper
    matthewjasper committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    94c11df View commit details
    Browse the repository at this point in the history

  6. Print closure signatures when reporting placeholder errors

    @matthewjasper
    matthewjasper committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    9337d4f View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Keep existing names of regions in placeholder_error

    @matthewjasper
    matthewjasper committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    f852160 View commit details
    Browse the repository at this point in the history