Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit only terminators when removing unneeded drops #81122

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 17, 2021

No functional changes intended

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2021
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Checking which error codes lack tests...
Found 435 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/compiler/rustc_mir/src/transform/remove_unneeded_drops.rs: too many trailing newlines (2)
some tidy checks failed

command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build"
expected success, got: exit code: 1

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 18, 2021

📌 Commit d0a7567 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2021
@bors
Copy link
Contributor

bors commented Jan 20, 2021

⌛ Testing commit d0a7567 with merge 370d85d51990d4973ca0d11f8646b0d32b0893fb...

@bors
Copy link
Contributor

bors commented Jan 20, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 20, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@m-ou-se
Copy link
Member

m-ou-se commented Jan 20, 2021

Looks like downloading the docker image got stuck in one of the runners.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2021
@bors
Copy link
Contributor

bors commented Jan 21, 2021

⌛ Testing commit d0a7567 with merge 65767e5...

@bors
Copy link
Contributor

bors commented Jan 21, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 65767e5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 21, 2021
@bors bors merged commit 65767e5 into rust-lang:master Jan 21, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 21, 2021
@tmiasko tmiasko deleted the no-drop branch January 21, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants