-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add suggestion for "ignore" doc code block #80580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 3 commits into
rust-lang:master
from
GuillaumeGomez:suggestion-ignore-codeblock-warn
Jan 3, 2021
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
5bf5b12
Add suggestion in case a "ignore" doc block has invalid rust code inside
GuillaumeGomez c3ae826
Add test for suggestion in case a "ignore" doc block has invalid rust…
GuillaumeGomez 7bc1eb4
Create a "is_ignore" variable instead of doing the comparison multipl…
GuillaumeGomez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// check-pass | ||
|
||
/// ```ignore (to-prevent-tidy-error) | ||
/// let heart = '❤️'; | ||
/// ``` | ||
//~^^^ WARN | ||
pub struct X; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
warning: could not parse code block as Rust code | ||
--> $DIR/ignore-block-help.rs:3:5 | ||
| | ||
LL | /// ```ignore (to-prevent-tidy-error) | ||
| _____^ | ||
LL | | /// let heart = '❤️'; | ||
LL | | /// ``` | ||
| |_______^ | ||
| | ||
= note: error from rustc: character literal may only contain one codepoint | ||
help: `ignore` code blocks require valid Rust code for syntax highlighting. Mark blocks that do not contain Rust code as text | ||
| | ||
LL | /// ```text,ignore (to-prevent-tidy-error) | ||
| ^^^^^^^^ | ||
|
||
warning: 1 warning emitted | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.