Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cleanup markdown span handling" #80381

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Revert "Cleanup markdown span handling" #80381

merged 1 commit into from
Dec 30, 2020

Commits on Dec 26, 2020

  1. Revert "Cleanup markdown span handling"

    This caused a diagnostic regression, originally it was:
    
    ```
    warning: unresolved link to `std::process::Comman`
     --> link.rs:3:10
      |
    3 | //! [a]: std::process::Comman
      |          ^^^^^^^^^^^^^^^^^^^^ no item named `Comman` in module `process`
      |
      = note: `#[warn(broken_intra_doc_links)]` on by default
    ```
    but after that PR rustdoc now displays
    ```
    warning: unresolved link to `std::process::Comman`
     --> link.rs:1:14
      |
    1 | //! Links to [a] [link][a]
      |              ^^^ no item named `Comman` in module `process`
      |
      = note: `#[warn(broken_intra_doc_links)]` on by default
    ```
    which IMO is much less clear.
    Joshua Nelson authored and jyn514 committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    0f25712 View commit details
    Browse the repository at this point in the history