-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make ast::Lifetime contain ast::Name instead of ast::ident #8016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
let ext_cx = cx.ext_cx; | ||
|
||
// The vector of test_descs for this crate | ||
let test_descs = mk_test_descs(cx); | ||
|
||
let tt = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work! Could you put a note here, e.g.
// NOTE: Cannot use quote_item due to stage0 and #7743, revert after a snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I just want to add something like FIXME, but don't know how to express that uniformly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this:
// FIXME: Cannot use lifetimes in quote_item due to stage0 and #7743, revert after a snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, but it has to be a NOTE
, or you have to file an issue, and write FIXME #nnnn ...
(which is fine too). make tidy
doesn't allow FIXME
without an issue number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, get it.
@lilac in the future, when you update a PR, do |
@cmr OK, thanks! |
I'm interested, because afaict there's not actually any shared code between this and #8103 . FWIW, @graydon tells me that he reduced the failure to this code:
Unfortunately, I don't have a Windows machine to reproduce this failure. If you ( @lilac ) do, perhaps you can see whether this code triggers the failure on your PR, too? Best, John |
@jbclements Sorry, I don't have a Windows machine neither. And I am quite surprised that two unrelated pieces of code result in the same error. Maybe because the macro usage and my manual AST tree building both call some underlying AST related codes? |
r? @huonw |
Hm, @lilac, this doesn't merge cleanly, could you rebase on top of master? |
@huonw Rebase done. Do I need to close this PR and create a new PR after rebase? |
Nope, no need for a new PR, just force pushing the updated commits to this PR is fine. |
r? @huonw |
@bors: retry |
(You need to be a reviewer to We've accumulated a long chain of commits, could you squash them into the first one since it's all a single feature? |
@lilac Needs a rebase. |
Closing due to lack of activity. Please reopen if you have time to rebase it! |
my patch went through, so this one might as well. I'll re-open it when I have time to do some baby-sitting. |
Add more descriptive help info for `needless_question_mark` closes rust-lang#8016 changelog: [`needless_question_mark`] help suggestion now explains what should be changed
Fixes #7743. To make the compiler happy, I rewrite a use case of the "quote_item" macro. After we get a compiler snapshot that includes this change, the manual ast construction can be reverted back to using "quote_item".