-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Normalize <X as Y>::T
for rustdoc"
#79469
Conversation
@jyn514: It looks like the PR checks didn't run for some reason. Could you amend and force-push your commit to try to make them run? |
I'm not very familiar with the original PR, but this looks good to me. r? @oli-obk to make sure that I'm not missing anything. |
I'm not at a computer right now, if someone could force push to my branch that would be great. |
To avoid code churn, it might be a good idea to just add |
Another regression #77467 introduced: Rustdoc no long respects type aliases. |
I'm trying that locally right now. Will force push soonish. |
3224fdb
to
817dbf2
Compare
817dbf2
to
8b81bb8
Compare
@bors r+ |
📌 Commit 8b81bb8 has been approved by |
Note: this is not a regression, and there's no type alias involved. |
@bors p=5 This fixes a P-critical regression. |
☀️ Test successful - checks-actions |
Reverts #77467 by disabling normalization. See #79459; I intend to reland normalization once that's fixed.
r? @Aaron1011
cc @oli-obk @GuillaumeGomez