Stabilise then
#79299
Merged
Stabilise then
#79299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
T-libs-api
jyn514
approved these changes
Nov 22, 2020
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
stabilise-then
branch
from
b2297dc to
f8fe8e3
Compare
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
stabilise-then
branch
from
f8fe8e3 to
cf32afc
Compare
This was referenced Nov 22, 2020
|
Thanks! @bors r+ |
|
📌 Commit cf32afc has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 22, 2020
Stabilise `then` Stabilises the lazy variant of rust-lang#64260 now that the FCP [has ended](rust-lang#64260 (comment)). I've kept the original feature gate `bool_to_option` for the strict variant (`then_some`), and created a new insta-stable feature gate `lazy_bool_to_option` for `then`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#76941 (Add f{32,64}::is_subnormal) - rust-lang#77697 (Split each iterator adapter and source into individual modules) - rust-lang#78305 (Stabilize alloc::Layout const functions) - rust-lang#78608 (Stabilize refcell_take) - rust-lang#78793 (Clean up `StructuralEq` docs) - rust-lang#79267 (BTreeMap: address namespace conflicts) - rust-lang#79293 (Add test for eval order for a+=b) - rust-lang#79295 (BTreeMap: fix minor testing mistakes in rust-lang#78903) - rust-lang#79297 (BTreeMap: swap the names of NodeRef::new and Root::new_leaf) - rust-lang#79299 (Stabilise `then`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
This seems like it should be |
jyn514
added
the
relnotes
g2p
pushed a commit
to g2p/rustls-native-certs
that referenced
this pull request
Oct 5, 2021
rustls uses bool::then, for example, stabilized in 1.50: rust-lang/rust#79299 Note that their real MSRV is 1.52.1 so this may need to be bumped further.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilises the lazy variant of #64260 now that the FCP has ended.
I've kept the original feature gate
bool_to_optionfor the strict variant (then_some), and created a new insta-stable feature gatelazy_bool_to_optionforthen.