Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the compiler with -Ctarget-cpu=x86-64-v4 #79044

Closed
wants to merge 1 commit into from

Conversation

est31
Copy link
Member

@est31 est31 commented Nov 14, 2020

Sister PR of #79043 . Main difference is v4 instead of v2.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2020
@est31 est31 changed the title Add support for x86-64-{2,3,4} target CPUs and pass -Ctarget-cpu=x86-64-v4 Build the compiler with -Ctarget-cpu=x86-64-v4 Nov 14, 2020
@est31
Copy link
Member Author

est31 commented Nov 14, 2020

Oh wait, v4 is not supported by the perf hardware: #79043 (comment)

@est31 est31 closed this Nov 14, 2020
@Mark-Simulacrum
Copy link
Member

(There's also no need for a separate PR for this, you can just push to the v2 PR and we can enqueue another perf run there).

@est31
Copy link
Member Author

est31 commented Nov 14, 2020

@Mark-Simulacrum didn't know that works. Will do it in that PR then!

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
[command]/usr/bin/git config --local http.https://github.com/.extraheader AUTHORIZATION: basic ***
##[endgroup]
##[group]Fetching the repository
[command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=2 origin +15b803db2a327add510127d2c3200aed0fc9cf01:refs/remotes/pull/79044/merge
---
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
skip untracked path cpu-usage.csv during rustfmt invocations
skip untracked path src/doc/book/ during rustfmt invocations
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/src/bootstrap/compile.rs at line 522:
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/bootstrap/compile.rs"` failed.
 }
 
 
-pub fn rustc_cargo(builder: &Builder<'_>, cargo: &mut Cargo, target: TargetSelection, compiler: Compiler) {
+pub fn rustc_cargo(
+    builder: &Builder<'_>,
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
+    cargo: &mut Cargo,
+    compiler: Compiler,
+) {
     cargo
     cargo
         .arg("--features")
         .arg(builder.rustc_features())
Diff in /checkout/src/bootstrap/compile.rs at line 531:
     rustc_cargo_env(builder, cargo, target, compiler);
 
 
-pub fn rustc_cargo_env(builder: &Builder<'_>, cargo: &mut Cargo, target: TargetSelection, compiler: Compiler) {
+pub fn rustc_cargo_env(
+    builder: &Builder<'_>,
+    cargo: &mut Cargo,
+    compiler: Compiler,
+) {
+) {
     // Set some configuration variables picked up by build scripts and
     // the compiler alike
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 src/tools/tidy
Build completed unsuccessfully in 0:00:20
== clock drift check ==
  local time: Sat Nov 14 15:44:20 UTC 2020

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants