-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #78956
Rollup of 11 pull requests #78956
Commits on Oct 22, 2020
-
Dogfood Duration API in std::time tests
This expands time's test suite to use more and in more places the range of methods and constants added to Duration in recent proposals for the sake of testing more API surface area and improving legibility.
Configuration menu - View commit details
-
Copy full SHA for d72d5f4 - Browse repository at this point
Copy the full SHA d72d5f4View commit details -
Duration::zero() -> Duration::ZERO
Duration::ZERO composes better with match and various other things, at the cost of an occasional parens, and results in less work for the optimizer, so let's use that instead.
Configuration menu - View commit details
-
Copy full SHA for ef027a1 - Browse repository at this point
Copy the full SHA ef027a1View commit details
Commits on Oct 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b989d46 - Browse repository at this point
Copy the full SHA b989d46View commit details
Commits on Oct 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for af4d178 - Browse repository at this point
Copy the full SHA af4d178View commit details -
Duration::ZERO supercedes it in effect.
Configuration menu - View commit details
-
Copy full SHA for 82f3a23 - Browse repository at this point
Copy the full SHA 82f3a23View commit details
Commits on Nov 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 439171e - Browse repository at this point
Copy the full SHA 439171eView commit details
Commits on Nov 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 685fd53 - Browse repository at this point
Copy the full SHA 685fd53View commit details
Commits on Nov 9, 2020
-
Support inlining diverging function calls
Additionally introduce storage markers for all temporaries created by the inliner. The temporary introduced for destination rebrorrow, didn't use them previously.
Configuration menu - View commit details
-
Copy full SHA for ffa70d7 - Browse repository at this point
Copy the full SHA ffa70d7View commit details
Commits on Nov 10, 2020
-
Add flags customizing behaviour of MIR inlining
* `-Zinline-mir-threshold` to change the default threshold. * `-Zinline-mir-hint-threshold` to change the threshold used by functions with inline hint.
Configuration menu - View commit details
-
Copy full SHA for c8943c6 - Browse repository at this point
Copy the full SHA c8943c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03eec5c - Browse repository at this point
Copy the full SHA 03eec5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce91c68 - Browse repository at this point
Copy the full SHA ce91c68View commit details
Commits on Nov 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ca17a91 - Browse repository at this point
Copy the full SHA ca17a91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1854425 - Browse repository at this point
Copy the full SHA 1854425View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2453ce7 - Browse repository at this point
Copy the full SHA 2453ce7View commit details -
Rollup merge of #78216 - workingjubilee:duration-zero, r=m-ou-se
Duration::zero() -> Duration::ZERO In review for #72790, whether or not a constant or a function should be favored for `#![feature(duration_zero)]` was seen as an open question. In #73544 (comment) an invitation was opened to either stabilize the methods or propose a switch to the constant value, supplemented with reasoning. Followup comments suggested community preference leans towards the const ZERO, which would be reason enough. ZERO also "makes sense" beside existing associated consts for Duration. It is ever so slightly awkward to have a series of constants specifying 1 of various units but leave 0 as a method, especially when they are side-by-side in code. It seems unintuitive for the one non-dynamic value (that isn't from Default) to be not-a-const, which could hurt discoverability of the associated constants overall. Elsewhere in `std`, methods for obtaining a constant value were even deprecated, as seen with [std::u32::min_value](https://doc.rust-lang.org/std/primitive.u32.html#method.min_value). Most importantly, ZERO costs less to use. A match supports a const pattern, but const fn can only be used if evaluated through a const context such as an inline `const { const_fn() }` or a `const NAME: T = const_fn()` declaration elsewhere. Likewise, while #73544 (comment) notes `Duration::zero()` can optimize to a constant value, "can" is not "will". Only const contexts have a strong promise of such. Even without that in mind, the comment in question still leans in favor of the constant for simplicity. As it costs less for a developer to use, may cost less to optimize, and seems to have more of a community consensus for it, the associated const seems best. r? ```@LukasKalbertodt```
Configuration menu - View commit details
-
Copy full SHA for 62f0a78 - Browse repository at this point
Copy the full SHA 62f0a78View commit details -
Rollup merge of #78354 - 12101111:rustbuild_profiler, r=Mark-Simulacrum
Support enable/disable sanitizers/profiler per target This PR add options under `[target.*]` of `config.toml` which can enable or disable sanitizers/profiler runtime for corresponding target. If these options are empty, the global options under `[build]` will take effect. Fix #78329
Configuration menu - View commit details
-
Copy full SHA for 194b968 - Browse repository at this point
Copy the full SHA 194b968View commit details -
Rollup merge of #78417 - ssomers:btree_chop_up_2, r=Mark-Simulacrum
BTreeMap: split off most code of append To complete #78056, move the last single-purpose pieces of code out of map.rs into a separate module. Also, tweaked documentation and safeness - I doubt think this code would be safe if the iterators passed in wouldn't be as sorted as the method says they should be - and bounds on MergeIterInner. r? ```@Mark-Simulacrum```
Configuration menu - View commit details
-
Copy full SHA for 56e0806 - Browse repository at this point
Copy the full SHA 56e0806View commit details -
Rollup merge of #78832 - lcnr:const-evaluatable-unevaluated, r=oli-obk
look at assoc ct, check the type of nodes an example where types matter are function objects, see the added test which previously passed. Now does a shallow comparison of unevaluated constants. r? ```@oli-obk```
Configuration menu - View commit details
-
Copy full SHA for 2e0a0b4 - Browse repository at this point
Copy the full SHA 2e0a0b4View commit details -
Rollup merge of #78873 - tmiasko:inline-opts, r=oli-obk
Add flags customizing behaviour of MIR inlining * `-Zinline-mir-threshold` to change the default threshold. * `-Zinline-mir-hint-threshold` to change the threshold used by functions with inline hint. Having those as configurable flags makes it possible to experiment with with different inlining thresholds and substantially increase test coverage of MIR inlining when used with increased thresholds (for example, necessary to test #78844).
Configuration menu - View commit details
-
Copy full SHA for 919177f - Browse repository at this point
Copy the full SHA 919177fView commit details -
Rollup merge of #78899 - tmiasko:inline-diverging, r=oli-obk
Support inlining diverging function calls The existing heuristic does penalize diverging calls to some degree, but since it never inlined them previously it might need some further modifications. Additionally introduce storage markers for all temporaries created by the inliner. The temporary introduced for destination rebrorrow, didn't use them previously.
Configuration menu - View commit details
-
Copy full SHA for 0b521e5 - Browse repository at this point
Copy the full SHA 0b521e5View commit details -
Rollup merge of #78923 - jyn514:intra-doc-comments, r=Manishearth
Cleanup and comment intra-doc link pass r? ```@Manishearth``` cc ```@seeplusplus```
Configuration menu - View commit details
-
Copy full SHA for a8a0c65 - Browse repository at this point
Copy the full SHA a8a0c65View commit details -
Rollup merge of #78929 - petrochenkov:linuxbase, r=joshtriplett
rustc_target: Move target env "gnu" from `linux_base` to `linux_gnu_base` Follow up to #77729. Changes the target spec hierarchy for Linux from ``` linux_base ├── linux_musl_base └── linux_uclibc_base ``` where `linux_base` is really `linux_gnu_base` and the inheriting targets replace target env "gnu" with "musl"/"uclibc" to ``` linux_base ├── linux_gnu_base ├── linux_musl_base └── linux_uclibc_base ``` which is slightly less confusing (I think).
Configuration menu - View commit details
-
Copy full SHA for 5ac0ae4 - Browse repository at this point
Copy the full SHA 5ac0ae4View commit details -
Rollup merge of #78930 - petrochenkov:notlikeandroid, r=Mark-Simulacrum
rustc_taret: Remove `TargetOptions::is_like_android` This option was replaced by more specific options and is no longer used by the compiler.
Configuration menu - View commit details
-
Copy full SHA for 904b658 - Browse repository at this point
Copy the full SHA 904b658View commit details -
Rollup merge of #78942 - eltociear:patch-1, r=jonas-schievink
Fix typo in comment occurences -> occurrences
Configuration menu - View commit details
-
Copy full SHA for f311458 - Browse repository at this point
Copy the full SHA f311458View commit details -
Rollup merge of #78947 - dalance:llvm_cov, r=Mark-Simulacrum
Ship llvm-cov through llvm-tools `llvm-cov` is used to generate coverage report with LLVM InstrProf-based code coverage #34701. So if `llvm-cov` is shipped through llvm-tools, users can try it easily accorging to the instruction of [The Rust Unstable Book](https://doc.rust-lang.org/nightly/unstable-book/compiler-flags/source-based-code-coverage.html).
Configuration menu - View commit details
-
Copy full SHA for 61c0a2c - Browse repository at this point
Copy the full SHA 61c0a2cView commit details