Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify output capturing #78714

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Simplify output capturing #78714

merged 5 commits into from
Nov 17, 2020

Commits on Nov 10, 2020

  1. Remove io::LocalOutput and use Arc<Mutex<dyn>> for local streams.

    @m-ou-se
    m-ou-se committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    72e9660 View commit details
    Browse the repository at this point in the history

  2. Update tests for updated set_panic.

    @m-ou-se
    m-ou-se committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    ccbce1d View commit details
    Browse the repository at this point in the history

  3. Use Vec<u8> for LOCAL_STD{OUT,ERR} instead of dyn Write. 

    It was only ever used with Vec<u8> anyway. This simplifies some things.

- It no longer needs to be flushed, because that's a no-op anyway for
  a Vec<u8>.

- Writing to a Vec<u8> never fails.

- No #[cfg(test)] code is needed anymore to use `realstd` instead of
  `std`, because Vec comes from alloc, not std (like Write).
    @m-ou-se
    m-ou-se committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    f534b75 View commit details
    Browse the repository at this point in the history

  4. Use Cell instead of RefCell for LOCAL_{STDOUT,STDERR}.

    @m-ou-se
    m-ou-se committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    08b7cb7 View commit details
    Browse the repository at this point in the history

  5. Merge set_panic and set_print into set_output_capture. 

    There were no use cases for setting them separately.
Merging them simplifies some things.
    @m-ou-se
    m-ou-se committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    aff7bd6 View commit details
    Browse the repository at this point in the history