Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #78451

Closed
wants to merge 37 commits into from
Closed

Rollup of 9 pull requests #78451

wants to merge 37 commits into from

Commits on Oct 25, 2020

  1. warn -> debug in collect

    lcnr committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    9dadcf8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e419ef View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. libc: 0.2.79 -> 0.2.80

    nagisa committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    00abef1 View commit details
    Browse the repository at this point in the history
  2. add fixme

    lcnr committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    8546a80 View commit details
    Browse the repository at this point in the history
  3. debug log AbstractConst::new

    lcnr committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    60bcc58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0cf3ce4 View commit details
    Browse the repository at this point in the history
  5. Remove tokens from foreign items in TokenStripper

    Fixes #78398
    
    I forgot to handle this case in #77255
    Aaron1011 committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    174ed0c View commit details
    Browse the repository at this point in the history
  6. build-manifest: add BUILD_MANIFEST_CHECKSUM_CACHE

    The checksum cache allows to reuse the calculated checksums between
    build-manifest and promote-release, or between multiple invocations of
    build-manifest.
    pietroalbini committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    c2f4bbd View commit details
    Browse the repository at this point in the history
  7. Fix some outdated comments

    nox committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    53fa22a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a3623e0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8cf1b0e View commit details
    Browse the repository at this point in the history
  10. Add basic test

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    a2f4afe View commit details
    Browse the repository at this point in the history
  11. Address review comments

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    8b65df0 View commit details
    Browse the repository at this point in the history
  12. Update doctest

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    ce95122 View commit details
    Browse the repository at this point in the history
  13. Tweak diagnostic

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5643a06 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    737bfef View commit details
    Browse the repository at this point in the history
  15. Address review comments

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    1bcd245 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    576eb2a View commit details
    Browse the repository at this point in the history
  17. Remove lint from clippy

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5ac1688 View commit details
    Browse the repository at this point in the history
  18. Fix doctest

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    6ba127d View commit details
    Browse the repository at this point in the history
  19. Implement -Z function-sections=yes|no

    This lets rustc users tweak whether all functions should be put in their own
    TEXT section, using whatever default value the target defines if the flag
    is missing.
    nox committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    0569422 View commit details
    Browse the repository at this point in the history
  20. Address review comments

    nathanwhit committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    cb8b901 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Configuration menu
    Copy the full SHA
    39941e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    650e3cb View commit details
    Browse the repository at this point in the history
  3. Fix test

    nathanwhit committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    572cd35 View commit details
    Browse the repository at this point in the history
  4. Fix typo in comment

    bugadani committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    da64d07 View commit details
    Browse the repository at this point in the history
  5. Fix typos in arena comments

    bugadani committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    99320b9 View commit details
    Browse the repository at this point in the history
  6. Fix typo in vec_graph

    bugadani committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b01c74b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of #75671 - nathanwhit:cstring-temp-lint, r=oli-obk

    Uplift `temporary-cstring-as-ptr` lint from `clippy` into rustc
    
    The general consensus seems to be that this lint covers a common enough mistake to warrant inclusion in rustc.
    The diagnostic message might need some tweaking, as I'm not sure the use of second-person perspective matches the rest of rustc, but I'd like to hear others' thoughts on that.
    
    (cc #53224).
    
    r? @oli-obk
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b2e935d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of #78365 - lcnr:const-eval-obj-safety, r=oli-obk

    check object safety of generic constants
    
    As `Self` can only be effectively used in constants with `const_evaluatable_checked` this should not matter outside of it.
    
    Implements the first item of #72219
    
    > Object safety interactions with constants
    
    r? @oli-obk for now cc @nikomatsakis
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3861024 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of #78378 - nagisa:nagisa/libc-up, r=Mark-Simulacrum

    libc: 0.2.79 -> 0.2.80
    
    This PR bumps the version of the libc crate from 0.2.79 to 0.2.80 in order to hopefully fix a build failure when building the standard library for the tier 3 `x86_64-unknown-dragonfly` target.
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3e49068 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of #78408 - Aaron1011:fix/remove-foreign-tokens, r=oli-obk

    Remove tokens from foreign items in `TokenStripper`
    
    Fixes #78398
    
    I forgot to handle this case in #77255
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    944a4b0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of #78409 - pietroalbini:build-manifest-checksum-cache, …

    …r=Mark-Simulacrum
    
    Add checksums cache to build-manifest
    
    During the release process we're currently calculating the SHA256 of each file three times:
    
    1. In `build-manifest`, to fill the `hash = "f00"` keys of the manifests.
    2. In `promote-release`, to generate the `.sha256` files.
    3. In `promote-release`, to generate the `.asc` GPG signatures.
    
    Calculations 1. and 2. could be merged into a single one if there was a way for `build-manifest` to pass the checksums it generated over to `promote-release`. Unfortunately calculation 3. can't be merged as GPG requires extra metadata to be hashed.
    
    This PR adds support for merging 1. and 2. by creating the `BUILD_MANIFEST_CHECKSUM_CACHE` environment variable, which points to a JSON file storing a cache of all the calculated checksums. `build-manifest` will load it at startup and avoid generating existing checksums, and it will dump its internal checksums cache into it when it exits successfully.
    
    This PR also allows to run `build-manifest` multiple times without the need to wait for checksums to be calculated in the following invocations. The speedup will allow to work torwards a fix for rust-lang/promote-release#15 without impacting the release process duration nor our storage costs.
    
    This PR can be reviewed commit-by-commit.
    r? @Mark-Simulacrum
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    163b322 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of #78414 - nox:function-sections, r=nagisa,bjorn3

    Implement -Z function-sections=yes|no
    
    This lets rustc users tweak whether all functions should be put in their own TEXT section, using whatever default value the target defines if the flag is missing.
    
    I'm having fun experimenting with musl libc and trying to implement the start symbol in Rust, that means avoiding code that requires relocations, and AFAIK putting everything in its own section makes the toolchain generate `GOTPCREL` relocations for symbols that could use plain old PC-relative addressing (at least on `x86_64`) if they were all in the same section.
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    f29e191 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of #78415 - tgnottingham:expn_id_tag_hash, r=Aaron1011

    rustc_span: avoid hashing ExpnId tag when using cached hash
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    afbc67b View commit details
    Browse the repository at this point in the history
  14. Rollup merge of #78431 - Rustin-Liu:rustin-patch-lint, r=estebank

    Prefer new associated numeric consts in float error messages
    
    CC #78382
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2ddaa60 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of #78447 - bugadani:typo, r=matthewjasper

    Fix typo in  comment
    
    I hope I got all the typos in that word. :)
    jonas-schievink authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    733e3c5 View commit details
    Browse the repository at this point in the history