-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Mark inout asm! operands as used in liveness pass #77976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cc0b718
Mark inout asm! operands as used in liveness pass
oliviacrain fd193f2
Treat InOut variables like other input variables
oliviacrain 17c6c59
Mark InOut operands as used in RWU table with write_place
oliviacrain 8f0bced
Refactor liveness-issue-77915 to liveness-asm and improve tests
oliviacrain 2720b2d
Limit liveness-asm tests to x86_64
oliviacrain dc29c7a
Bless liveness-asm output
oliviacrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Ensure inout asm! operands are marked as used by the liveness pass | ||
|
||
// only-x86_64 | ||
// check-pass | ||
|
||
#![feature(asm)] | ||
#![allow(dead_code)] | ||
#![warn(unused_assignments)] | ||
#![warn(unused_variables)] | ||
|
||
// Test the single inout case | ||
unsafe fn f1(mut src: *const u8) { | ||
asm!("/*{0}*/", inout(reg) src); //~ WARN value assigned to `src` is never read | ||
} | ||
|
||
unsafe fn f2(mut src: *const u8) -> *const u8 { | ||
asm!("/*{0}*/", inout(reg) src); | ||
src | ||
} | ||
|
||
// Test the split inout case | ||
unsafe fn f3(mut src: *const u8) { | ||
asm!("/*{0}*/", inout(reg) src => src); //~ WARN value assigned to `src` is never read | ||
} | ||
|
||
unsafe fn f4(mut src: *const u8) -> *const u8 { | ||
asm!("/*{0}*/", inout(reg) src => src); | ||
src | ||
} | ||
|
||
// Tests the use of field projections | ||
struct S { | ||
field: *mut u8, | ||
} | ||
|
||
unsafe fn f5(src: &mut S) { | ||
asm!("/*{0}*/", inout(reg) src.field); | ||
} | ||
|
||
unsafe fn f6(src: &mut S) { | ||
asm!("/*{0}*/", inout(reg) src.field => src.field); | ||
} | ||
|
||
fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
warning: value assigned to `src` is never read | ||
--> $DIR/liveness-asm.rs:13:32 | ||
| | ||
LL | asm!("/*{0}*/", inout(reg) src); | ||
| ^^^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/liveness-asm.rs:8:9 | ||
| | ||
LL | #![warn(unused_assignments)] | ||
| ^^^^^^^^^^^^^^^^^^ | ||
= help: maybe it is overwritten before being read? | ||
|
||
warning: value assigned to `src` is never read | ||
--> $DIR/liveness-asm.rs:23:39 | ||
| | ||
LL | asm!("/*{0}*/", inout(reg) src => src); | ||
| ^^^ | ||
| | ||
= help: maybe it is overwritten before being read? | ||
|
||
warning: 2 warnings emitted | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.