Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min_const_generics diagnostics improvements #77825

Merged
merged 5 commits into from
Oct 14, 2020
Merged

min_const_generics diagnostics improvements #77825

merged 5 commits into from
Oct 14, 2020

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Oct 11, 2020

As disscussed in zulip/project-const-generics/non-trivial anonymous constant.

This is my first PR on the compiler.

@lcnr is mentoring me on this PR.

Related to #60551.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2020
@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints F-min_const_generics T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 11, 2020

r? @lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned eddyb Oct 11, 2020
@lcnr
Copy link
Contributor

lcnr commented Oct 12, 2020

Nice, good job 👍

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 12, 2020

📌 Commit d7029cb has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2020
@varkor
Copy link
Member

varkor commented Oct 12, 2020

Having taken a look at the errors in practice, I think there are a couple of minor tweaks that could make them more readable, so I'm going to leave a bit more feedback. Sorry for the trouble.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2020
varkor
varkor reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@varkor varkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can discuss this further on Zulip if any of my suggestions are contentious.

compiler/rustc_resolve/src/diagnostics.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/diagnostics.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/diagnostics.rs Outdated Show resolved Hide resolved
@eopb @varkor
Make error help clearer
eec4436 
Co-authored-by: varkor <github@varkor.com>
eopb and others added 3 commits October 12, 2020 15:57
@eopb @varkor
Remove a little jargon from error
e62da8f 
Co-authored-by: varkor <github@varkor.com>
@eopb @varkor
A little rewording
facb38d 
Co-authored-by: varkor <github@varkor.com>
@eopb
Bless expected errors
79351b1
@varkor
Copy link
Member

varkor commented Oct 12, 2020

I'm happy with the diagnostics now, so if @lcnr is also happy, we're good to go :)

@lcnr
Copy link
Contributor

lcnr commented Oct 13, 2020

lgtm

@bors r+

@bors
Copy link
Contributor

bors commented Oct 13, 2020

📌 Commit 79351b1 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 13, 2020
@JohnTitor
Rollup merge of rust-lang#77825 - ethanboxx:min_const_generics_diagno…
807b981 
…stic, r=lcnr

`min_const_generics` diagnostics improvements

As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants).

This is my first PR on the compiler.

@lcnr is mentoring me on this PR.

Related to rust-lang#60551.
@JohnTitor JohnTitor mentioned this pull request Oct 13, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 13, 2020
@JohnTitor
Rollup merge of rust-lang#77825 - ethanboxx:min_const_generics_diagno…
0a83cb9 
…stic, r=lcnr

`min_const_generics` diagnostics improvements

As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants).

This is my first PR on the compiler.

@lcnr is mentoring me on this PR.

Related to rust-lang#60551.
@JohnTitor JohnTitor mentioned this pull request Oct 13, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2020
@bors
Auto merge of rust-lang#77917 - JohnTitor:rollup-e47h2qt, r=JohnTitor
f243a2a 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#77239 (Enable building Cargo for aarch64-apple-darwin)
 - rust-lang#77569 (BTreeMap: type-specific variants of node_as_mut and cast_unchecked)
 - rust-lang#77719 (Remove unnecessary rustc_const_stable attributes.)
 - rust-lang#77722 (Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).)
 - rust-lang#77725 (Add regression issue template)
 - rust-lang#77776 ( Give an error when running `x.py test --stage 0 src/test/ui`)
 - rust-lang#77786 (Mention rustdoc in `x.py setup`)
 - rust-lang#77825 (`min_const_generics` diagnostics improvements)
 - rust-lang#77868 (Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component)
 - rust-lang#77884 (Use Option::unwrap_or instead of open-coding it)
 - rust-lang#77886 (Replace trivial bool matches with the `matches!` macro)
 - rust-lang#77892 (Replace absolute paths with relative ones)
 - rust-lang#77895 (Include aarch64-apple-darwin in the dist manifests)
 - rust-lang#77909 (bootstrap: set correct path for the build-manifest binary)

Failed merges:

 - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests)

r? `@ghost`
@bors bors merged commit c44cc7e into rust-lang:master Oct 14, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 14, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Oct 19, 2020
Open
@lcnr lcnr mentioned this pull request Nov 17, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

@varkor varkor varkor left review comments

Assignees

@lcnr lcnr

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
8 participants
@eopb @rust-highfive @jyn514 @lcnr @bors @varkor @eddyb @rustbot