Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify some code in rustc_llvm/build.rs now that LLVM 8 is required #77690

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Simplify some code in rustc_llvm/build.rs now that LLVM 8 is required #77690

merged 1 commit into from
Oct 9, 2020

Conversation

est31
Copy link
Member

@est31 est31 commented Oct 8, 2020

LLVM 8 is required since 8506bb0
so this is safe to do.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 8, 2020

📌 Commit 8b8e706 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2020
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Testing commit 8b8e706 with merge 685dd66fd6995c83cf1d909a0f3c42a83beddb1f...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2020
@est31 est31 mentioned this pull request Oct 9, 2020
Merged
@est31
Copy link
Member Author

est31 commented Oct 9, 2020

Network hickup:

 warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/lazycell/1.3.0/download`, got 503
warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/lazycell/1.3.0/download`, got 503
error: failed to download from `https://crates.io/api/v1/crates/lazycell/1.3.0/download`

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2020
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Testing commit 8b8e706 with merge 53a4c3b...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing 53a4c3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2020
@bors bors merged commit 53a4c3b into rust-lang:master Oct 9, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
5 participants
@est31 @rust-highfive @matthewjasper @bors @rustbot