Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest MAX constant if -1 is assigned to unsigned type #77578

Merged
merged 1 commit into from
Oct 9, 2020
Merged

suggest MAX constant if -1 is assigned to unsigned type #77578

merged 1 commit into from
Oct 9, 2020

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Oct 5, 2020

Fixes #76413.
Fixes #77416.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2020
davidtwco
davidtwco requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation wise, this looks great. I'd like to see the message changed slightly, I don't think we've got a definitive style guide here but it currently reads slightly awkwardly to me.

compiler/rustc_typeck/src/check/op.rs Outdated Show resolved Hide resolved
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 8, 2020

📌 Commit ced11a8 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 8, 2020
@Dylan-DPC
Rollup merge of rust-lang#77578 - euclio:max-suggestion, r=davidtwco
ad06647 
suggest `MAX` constant if -1 is assigned to unsigned type

Fixes rust-lang#76413.
Fixes rust-lang#77416.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 8, 2020
Closed
@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Testing commit ced11a8 with merge 2359ecc...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 2359ecc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2020
@bors bors merged commit 2359ecc into rust-lang:master Oct 9, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lonami Lonami Lonami left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
6 participants
@euclio @rust-highfive @davidtwco @bors @Lonami @rustbot