Disallow overriding forbid in same scope #77534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant in the language. (Note that the fact this test existed is a slight sign that we may need a crater run on this bugfix...)
That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to forbidding foo.
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
commented
Oct 4, 2020
| @@ -37,13 +37,5 @@ LL | #![deny(clippy::restriction)] | |||
| | | |||
| = help: try enabling only the lints you really need | |||
|
|
|||
| error: restriction lints are not meant to be all enabled | |||
There was a problem hiding this comment.
My guess is that the original inclusion here was intended to test that any level of blanket restriction enablement (including forbid) was covered, but given that the code in question blanket covers everything except allow it feels like this should be sufficient (and adding a separate test does not feel worth it).
|
@bors r+ |
|
📌 Commit afa2a67 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 6, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#76388 (Add a note about the panic behavior of math operations on time objects) - rust-lang#76855 (Revamp rustdoc docs about documentation using `cfg`) - rust-lang#76995 (Reduce boilerplate with the matches! macro) - rust-lang#77228 (Add missing examples for MaybeUninit) - rust-lang#77528 (Avoid unchecked casts in net parser) - rust-lang#77534 (Disallow overriding forbid in same scope) - rust-lang#77555 (Allow anyone to set regression labels) - rust-lang#77558 (Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml}) - rust-lang#77559 (Fix rustdoc warnings about invalid Rust syntax) - rust-lang#77560 (Fix LitKind's byte buffer to use refcounted slice) - rust-lang#77573 (Hint doc use convert::identity relative link) - rust-lang#77587 (Fix span for unicode escape suggestion.) - rust-lang#77591 (Record `expansion_that_defined` into crate metadata) Failed merges: r? `@ghost`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 9, 2020
…w-override-forbid-in-same-scope, r=petrochenkov Disallow overriding forbid in same scope Rebased rust-lang#73379. Fixes rust-lang#70819.
Mark-Simulacrum
deleted the
issue-70819-disallow-override-forbid-in-same-scope
branch
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2020
…ulacrum [beta] backports * Revert rust-lang#77534 fixing rust-lang#77713 on beta, principled fix landed on master * fix soundness issue in `make_contiguous` rust-lang#79814 * Fix exhaustiveness in case a byte string literal is used at slice type rust-lang#79072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #73379.
Fixes #70819.