Skip to content

Unbox mutexes and condvars on some platforms #77380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 4, 2020
Merged

Unbox mutexes and condvars on some platforms #77380

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a8c2d4f
Move boxing and mutex checking logic of condvar into sys_common.
m-ou-se Sep 30, 2020
58deb70
Make it possible to have unboxed mutexes on specific platforms.
m-ou-se Sep 30, 2020
def5188
No longer put cloudabi mutexes in a box.
m-ou-se Sep 30, 2020
2f03867
No longer put mutexes on the 'unsupported' platform in a box.
m-ou-se Sep 30, 2020
4f1353e
No longer put wasm mutexes in a box.
m-ou-se Sep 30, 2020
dc81cbd
No longer put windows mutexes in a box.
m-ou-se Sep 30, 2020
b181f5a
Make it possible to have unboxed condvars on specific platforms.
m-ou-se Sep 30, 2020
5769a46
No longer put cloudabi condvars in a box.
m-ou-se Sep 30, 2020
7f56a35
No longer put condvars on the 'unsupported' platform in a box.
m-ou-se Sep 30, 2020
ec69a85
No longer put wasm condvars in a box.
m-ou-se Sep 30, 2020
f3837e7
No longer put windows condvars in a box.
m-ou-se Sep 30, 2020
b1ce7a3
Disable condvar::two_mutexes test on non-unix platforms.
m-ou-se Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No longer put mutexes on the 'unsupported' platform in a box. 
These mutexes are just a bool (in a cell), so can be moved without
problems.
  • Loading branch information
@m-ou-se
m-ou-se committed Oct 2, 2020
commit 2f0386771d17703d8e5ea9abef3359770b51af3f
2 changes: 1 addition & 1 deletion library/std/src/sys/unsupported/mutex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pub struct Mutex {
locked: UnsafeCell<bool>,
}

pub type MovableMutex = Box<Mutex>;
pub type MovableMutex = Mutex;

unsafe impl Send for Mutex {}
unsafe impl Sync for Mutex {} // no threads on this platform
Expand Down