Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally capture tokens for attributes. #77255

Merged
merged 4 commits into from
Oct 24, 2020
Merged

Unconditionally capture tokens for attributes. #77255

merged 4 commits into from
Oct 24, 2020

Commits on Oct 21, 2020

  1. Unconditionally capture tokens for attributes. 

    This allows us to avoid synthesizing tokens in `prepend_attr`, since we
have the original tokens available.

We still need to synthesize tokens when expanding `cfg_attr`,
but this is an unavoidable consequence of the syntax of `cfg_attr` -
the user does not supply the `#` and `[]` tokens that a `cfg_attr`
expands to.
    @Aaron1011
    Aaron1011 committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    b9b2546 View commit details
    Browse the repository at this point in the history

  2. Strip tokens before printing AST JSON

    @Aaron1011
    Aaron1011 committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    37b25e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Don't create an empty LazyTokenStream

    @Aaron1011
    Aaron1011 committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    920bed1 View commit details
    Browse the repository at this point in the history

  2. Only call collect_tokens when we have an attribute to parse

    @Aaron1011
    Aaron1011 committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    5c7d8d0 View commit details
    Browse the repository at this point in the history