Add rust-dev component to support rustc development #76332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
bootstrap-llvm
branch
from
d4d33b3
to
49be8cf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-author
Is this a follow-up PR you haven't yet made? Giant thank you for working on this though ❤️ |
Mark-Simulacrum
force-pushed
the
bootstrap-llvm
branch
from
dca4809
to
f61d7be
Compare
|
Let's try r? @pietroalbini @bors try -- should've fixed the CI error in latest push |
|
⌛ Trying commit f61d7bebb37ecbe0a63d734f8e1e8d2c39c8c01d with merge a4fb0b111d9f14089158e58138a74f4ca75e3314... |
|
☀️ Try build successful - checks-actions, checks-azure |
jyn514
added
the
T-infra
Mark-Simulacrum
added
S-waiting-on-review
|
☀️ Try build successful - checks-actions, checks-azure |
This currently includes libLLVM, llvm-config, and FileCheck, but will perhaps expand to more tooling overtime. It should be considered entirely unstable and may change at any time.
Mark-Simulacrum
force-pushed
the
bootstrap-llvm
branch
from
8c811a4
to
aa4554f
Compare
|
@pietroalbini Update to rust-dev, should be good to go -- try build exposed a single case where I missed the llvm-tools name but that should be fixed now. |
|
@bors r+ Thanks! |
|
📌 Commit aa4554f has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
changed the title
|
⌛ Testing commit aa4554f with merge 82c83c40f35894063fdc7d0917426234d6a350ed... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Spurious: @bors retry cc @rust-lang/crates-io , this seems to have been happening a lot lately. |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
jyn514
added
the
T-bootstrap
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 12, 2020
…hton Download LLVM from CI to bootstrap (linux-only to start) This follows rust-lang#76332, adding support for using CI-built LLVM rather than building it locally. This should essentially "just work," but is left off by default in this PR. While we can support downloading LLVM for multiple host triples, this currently only downloads it for the build triple. That said, it should be possible to expand this relatively easily should multiple host triples be desired. Most people shouldn't be adjusting host/target triples though, so this should cover most use cases. Currently this downloads LLVM for the last bors-authored commit in the `git log`. This is a bit suboptimal -- we want the last bors-authored commit that touched the llvm-project submodule in basically all cases. But for now this just adds an extra ~20 MB download when rebasing atop latest master. Once we have a submodule bump landing after rust-lang#76332, we can fix this behavior to reduce downloads further.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2020
Download LLVM from CI to bootstrap (linux-only to start) This follows rust-lang#76332, adding support for using CI-built LLVM rather than building it locally. This should essentially "just work," but is left off by default in this PR. While we can support downloading LLVM for multiple host triples, this currently only downloads it for the build triple. That said, it should be possible to expand this relatively easily should multiple host triples be desired. Most people shouldn't be adjusting host/target triples though, so this should cover most use cases. Currently this downloads LLVM for the last bors-authored commit in the `git log`. This is a bit suboptimal -- we want the last bors-authored commit that touched the llvm-project submodule in basically all cases. But for now this just adds an extra ~20 MB download when rebasing atop latest master. Once we have a submodule bump landing after rust-lang#76332, we can fix this behavior to reduce downloads further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory work for permitting rustc developers to use CI-built LLVM rather than building it locally. Unlike distro-built LLVM, CI built LLVM is essentially guaranteed to behave perfectly for local development -- it is fully up to date, and carries all necessary patches.
This is a separate PR from #76349 because it needs to land before that one, since we want a master build with the full CI LLVM to be available for easier testing.