Condense StringReader's API to a single function #76286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 4231fbc has been approved by |
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? `@petrochenkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @petrochenkov
Ok, suddenly the whole thing collapse to just one public function with sane-ish interface :0)