Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unions: test move behavior of non-Copy fields #75559

Merged
merged 4 commits into from
Sep 14, 2020

Conversation

RalfJung
Copy link
Member

This test ensures the behaviors suggested by @petrochenkov here.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Aug 24, 2020

@joshtriplett IIRC you had some interest in stabilizing more of unions; could you maybe help review this?

@Dylan-DPC-zz
Copy link

r? @joshtriplett

@RalfJung RalfJung force-pushed the union-test-move branch 2 times, most recently from 5249b39 to 9c16cc2 Compare August 31, 2020 08:15
@RalfJung
Copy link
Member Author

RalfJung commented Sep 5, 2020

@joshtriplett this is ready for another round of review.

@joshtriplett
Copy link
Member

LGTM.

@RalfJung
Copy link
Member Author

@bors r=joshtriplett rollup

@bors
Copy link
Contributor

bors commented Sep 13, 2020

📌 Commit 9c16cc2 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 13, 2020
…plett

unions: test move behavior of non-Copy fields

This test ensures the behaviors suggested by @petrochenkov [here](rust-lang#32836 (comment)).
@RalfJung
Copy link
Member Author

Failed in #76664 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2020
@RalfJung
Copy link
Member Author

@bors r=joshtriplett

@bors
Copy link
Contributor

bors commented Sep 13, 2020

📌 Commit 5dfe015 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2020
…as-schievink

Rollup of 12 pull requests

Successful merges:

 - rust-lang#75559 (unions: test move behavior of non-Copy fields)
 - rust-lang#76441 (Note that parallel-compiler = true causes tests to fail)
 - rust-lang#76527 (Remove internal and unstable MaybeUninit::UNINIT.)
 - rust-lang#76629 (Simplify iter zip struct doc)
 - rust-lang#76640 (Simplify SyncOnceCell's `take` and `drop`.)
 - rust-lang#76646 (Add mailmap entry)
 - rust-lang#76651 (Remove Windows details from Unix and VmWorks symlink() docstrings)
 - rust-lang#76663 (Simplify iter chain struct doc)
 - rust-lang#76665 (slice::from_raw_parts: explicitly mention that data must be initialized)
 - rust-lang#76667 (Fix CI LLVM to work on NixOS out of the box)
 - rust-lang#76668 (Add visualization of rustc span in doc)
 - rust-lang#76677 (note that test_stable_pointers does not reflect a stable guarantee)

Failed merges:

r? `@ghost`
@bors bors merged commit 409eb89 into rust-lang:master Sep 14, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 14, 2020
@RalfJung RalfJung deleted the union-test-move branch September 14, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants