Resolve char as a primitive even if there is a module in scope

[jyn514]

Closes #58699.
r? @Manishearth

[rust-highfive]

Some changes occurred in intra-doc-links.

cc @jyn514

[Manishearth]

We should avoid this branch if it's explicitly not specified as a type, yes?

[jyn514]

Oh you're right - this should happen if there's no disambiguator or if the disambiguator is type@, but if there's a different disambiguator we should skip it.

[jyn514]

Should be fixed now.

[Manishearth]

@bors r+

[bors]

📌 Commit 6d2b16fc7e9d82befdd864ec9327883424ac6668 has been approved by Manishearth

[bors]

⌛ Testing commit 6d2b16fc7e9d82befdd864ec9327883424ac6668 with merge f78b2bee99acf60e0086aa75572697d05f35b3b7...

[rust-log-analyzer]

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

skip untracked path cpu-usage.csv during rustfmt invocations
skip untracked path src/doc/book/ during rustfmt invocations
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/src/librustdoc/passes/collect_intra_doc_links.rs at line 218:
                     }
                     Res::Def(DefKind::Mod, _) => {
                         // This resolved to a module, but we want primitive types to take precedence instead.
-                        if matches!(disambiguator, None | Some(Disambiguator::Namespace(Namespace::TypeNS))) {
+                        if matches!(
+                            disambiguator,
+                            None | Some(Disambiguator::Namespace(Namespace::TypeNS))
+                        ) {
                             if let Some(prim) = is_primitive(path_str, ns) {
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustdoc/passes/collect_intra_doc_links.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
                                 if extra_fragment.is_some() {
                                     return Err(ErrorKind::AnchorFailure(AnchorFailure::Primitive));
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test
== clock drift check ==
  local time: Sun Aug  9 05:24:22 UTC 2020
  network time: Sun, 09 Aug 2020 05:24:22 GMT
== end clock drift check ==
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (2871) (node)
Terminate orphan process: pid (2899) (python)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

[bors]

💔 Test failed - checks-actions

[jyn514]

@bors r=manishearth

[bors]

📌 Commit b11e2f2 has been approved by manishearth