Forbid generic parameters in anon consts inside of type defaults #74487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
added
A-const-generics
|
This finishes the implementation of the required limitation discussed in https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/type.20of.20const.20parameters/near/203406561 |
|
@bors r+ |
|
📌 Commit 5cc40f3c091c9f057571641ca2fa04947409b5cc has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5cc40f3c091c9f057571641ca2fa04947409b5cc with merge 0d528478bb6829d402606cc81f78d091cb186a32... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
lcnr
force-pushed
the
const-in-ty-default
branch
from
5cc40f3
to
952fd0c
Compare
|
Rebased and updated the affected tests. @bors r=varkor |
|
📌 Commit 952fd0c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2020
…arth Rollup of 4 pull requests Successful merges: - rust-lang#73858 (Make more primitive integer methods const) - rust-lang#74487 (Forbid generic parameters in anon consts inside of type defaults) - rust-lang#74803 (rustbuild: fix bad usage of UNIX exec() in rustc wrapper) - rust-lang#74822 (More ensure stack to avoid segfault with increased `recursion_limit`) Failed merges: r? @ghost
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit a resolution error for
struct Foo<T, U = [u8; std::mem::size_of::<T>()]>.We are unable to support this with the way
ty::Genericsis currently used,so let's just forbid it entirely for now.
Fixes some ICE on stable, e.g.
r? @varkor @eddyb