Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] next #74219

Merged
merged 7 commits into from
Jul 13, 2020
Merged

[beta] next #74219

merged 7 commits into from
Jul 13, 2020

Commits on Jul 10, 2020

  1. rustdoc: Fix doc aliases with crate filtering 

    Fix a crash when searching for an alias contained in the currently selected filter crate.

Also remove alias search results for crates that should be filtered out.

The test suite needed to be fixed to actually take into account the crate filtering and check that there are no results when none are expected.
    @ollie27 @Mark-Simulacrum
    ollie27 authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    cbde61c View commit details
    Browse the repository at this point in the history

  2. rustdoc: Rename invalid_codeblock_attribute lint to be plural

    @ollie27 @Mark-Simulacrum
    ollie27 authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    13da8ab View commit details
    Browse the repository at this point in the history

  3. rustc_lexer: Simplify shebang parsing once more

    @petrochenkov @Mark-Simulacrum
    petrochenkov authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    5ceb946 View commit details
    Browse the repository at this point in the history

  4. Perform obligation deduplication to avoid buggy ExistentialMismatch 

    Fix rust-lang#59326.
    @estebank @Mark-Simulacrum
    estebank authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    04c208b View commit details
    Browse the repository at this point in the history

  5. Reoder order in which MinGW libs are linked

    @mati865 @Mark-Simulacrum
    mati865 authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    ffebd8a View commit details
    Browse the repository at this point in the history

  6. Change how compiler-builtins gets many CGUs 

    This commit intends to fix an accidental regression from rust-lang#70846. The
goal of rust-lang#70846 was to build compiler-builtins with a maximal number of
CGUs to ensure that each module in the source corresponds to an object
file. This high degree of control for compiler-builtins is desirable to
ensure that there's at most one exported symbol per CGU, ideally
enabling compiler-builtins to not conflict with the system libgcc as
often.

In rust-lang#70846, however, only part of the compiler understands that
compiler-builtins is built with many CGUs. The rest of the compiler
thinks it's building with `sess.codegen_units()`. Notably the
calculation of `sess.lto()` consults `sess.codegen_units()`, which when
there's only one CGU it disables ThinLTO. This means that
compiler-builtins is built without ThinLTO, which is quite harmful to
performance! This is the root of the cause from rust-lang#73135 where intrinsics
were found to not be inlining trivial functions.

The fix applied in this commit is to remove the special-casing of
compiler-builtins in the compiler. Instead the build system is now
responsible for special-casing compiler-builtins. It doesn't know
exactly how many CGUs will be needed but it passes a large number that
is assumed to be much greater than the number of source-level modules
needed. After reading the various locations in the compiler source, this
seemed like the best solution rather than adding more and more special
casing in the compiler for compiler-builtins.

Closes rust-lang#73135
    @alexcrichton @Mark-Simulacrum
    alexcrichton authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    25ac6de View commit details
    Browse the repository at this point in the history

  7. ci: fix wasm32 broken due to a NodeJS version bump 

    Emscripten's SDK recently bumped the version of NodeJS they shipped, but
our Dockerfile for the wasm32 builder hardcoded the version number. This
will cause consistent CI failures once the currently cached image is
rebuilt (either due to a change or due to the cache expiring).

This commit fixes the problem by finding the latest version of NodeJS in
the Emscripten SDK and symlinking it to a "latest" directory, which is
then added to the PATH.
    @pietroalbini @Mark-Simulacrum
    pietroalbini authored and Mark-Simulacrum committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    9ce2d97 View commit details
    Browse the repository at this point in the history