Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
tshepang
force-pushed
the
fix-rustdoc-warnings
branch
from
593590c to
0fd39e5
Compare
Contributor
There was a problem hiding this comment.
Use parens instead of brackets here.
Contributor
There was a problem hiding this comment.
I would say in this circumstance, the parenthesized word signifies how the word is being used in this context. That is, the phrase preceding the parenthetical is the definition for the word.
Member
Author
There was a problem hiding this comment.
I think I get it now... I thought those words were just continuations of the sentence
Contributor
|
r=me with nit fixed. @bors delegate+ |
Collaborator
|
✌️ @tshepang can now approve this pull request |
tshepang
force-pushed
the
fix-rustdoc-warnings
branch
from
0fd39e5 to
f3645ca
Compare
Member
Author
|
@bors r+ |
Collaborator
|
📌 Commit f3645ca has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
@bors r=ecstatic-morse |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit f3645ca has been approved by |
Member
Author
|
@bors r=ecstatic-morse rollup |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit f3645ca has been approved by |
Member
Author
|
@ecstatic-morse did I do the approval as you meant? |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 30, 2020
…static-morse remove rustdoc warnings
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 1, 2020
…static-morse remove rustdoc warnings
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 1, 2020
…static-morse remove rustdoc warnings
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2020
…arth Rollup of 17 pull requests Successful merges: - rust-lang#72071 (Added detailed error code explanation for issue E0687 in Rust compiler.) - rust-lang#72369 (Bring net/parser.rs up to modern up to date with modern rust patterns) - rust-lang#72445 (Stabilize `#[track_caller]`.) - rust-lang#73466 (impl From<char> for String) - rust-lang#73548 (remove rustdoc warnings) - rust-lang#73649 (Fix sentence structure) - rust-lang#73678 (Update Box::from_raw example to generalize better) - rust-lang#73705 (stop taking references in Relate) - rust-lang#73716 (Document the static keyword) - rust-lang#73752 (Remap Windows ERROR_INVALID_PARAMETER to ErrorKind::InvalidInput from Other) - rust-lang#73776 (Move terminator to new module) - rust-lang#73778 (Make `likely` and `unlikely` const, gated by feature `const_unlikely`) - rust-lang#73805 (Document the type keyword) - rust-lang#73806 (Use an 'approximate' universal upper bound when reporting region errors) - rust-lang#73828 (Fix wording for anonymous parameter name help) - rust-lang#73846 (Fix comma in debug_assert! docs) - rust-lang#73847 (Edit cursor.prev() method docs in lexer) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.