Skip to content

Disallow loading crates with non-ascii identifier name. #73305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Disallow loading crates with non-ascii identifier name. #73305

merged 1 commit into from
Jun 19, 2020

Conversation

@crlf0710
Copy link
Member

This turns off external crate loading with non-ascii identifier names.

cc #55467.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2020
@crlf0710
Copy link
Member Author

r? @petrochenkov

@crlf0710 crlf0710 force-pushed the disallow_loading_monsters branch from 388209b to 61cfc0c Compare June 13, 2020 05:32
@rust-highfive

This comment has been minimized.

Sign in to view
@crlf0710 crlf0710 force-pushed the disallow_loading_monsters branch from 61cfc0c to c245f46 Compare June 13, 2020 07:50
@petrochenkov
Copy link
Contributor

Could you put the error into fn resolve_crate instead and make it non-fatal?
I think that would be a better place.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
@crlf0710 crlf0710 force-pushed the disallow_loading_monsters branch from c245f46 to 7149485 Compare June 15, 2020 16:00
@crlf0710
Copy link
Member Author

Updated addressing the review comments.

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2020
@crlf0710 crlf0710 requested a review from petrochenkov June 15, 2020 16:03
petrochenkov
petrochenkov reviewed Jun 15, 2020
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2020
@crlf0710 crlf0710 force-pushed the disallow_loading_monsters branch from 7149485 to 1990f97 Compare June 16, 2020 13:36
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 16, 2020
@crlf0710 crlf0710 requested a review from petrochenkov June 16, 2020 14:03
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 16, 2020

📌 Commit 1990f97 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2020
@RalfJung
Copy link
Member

@bors rollup

@crlf0710 crlf0710 added the F-non_ascii_idents `#![feature(non_ascii_idents)]` label Jun 17, 2020
@Centril Centril mentioned this pull request Jun 17, 2020
Closed
23 tasks
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 17, 2020
@Dylan-DPC
Rollup merge of rust-lang#73305 - crlf0710:disallow_loading_monsters,…
8743c17 
… r=petrochenkov

Disallow loading crates with non-ascii identifier name.

This turns off external crate loading with non-ascii identifier names.

cc rust-lang#55467.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 17, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Jun 17, 2020
@tmandry
Rollup merge of rust-lang#73305 - crlf0710:disallow_loading_monsters,…
1b32e50 
… r=petrochenkov

Disallow loading crates with non-ascii identifier name.

This turns off external crate loading with non-ascii identifier names.

cc rust-lang#55467.
@tmandry tmandry mentioned this pull request Jun 17, 2020
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 18, 2020
@RalfJung
Rollup merge of rust-lang#73305 - crlf0710:disallow_loading_monsters,…
f8ae9a3 
… r=petrochenkov

Disallow loading crates with non-ascii identifier name.

This turns off external crate loading with non-ascii identifier names.

cc rust-lang#55467.
@RalfJung RalfJung mentioned this pull request Jun 18, 2020
Closed
@RalfJung RalfJung mentioned this pull request Jun 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2020
@bors
Auto merge of rust-lang#73498 - RalfJung:rollup-1mfjcju, r=RalfJung
63b441a 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#70740 (Enabling static-pie for musl)
 - rust-lang#72331 (Report error when casting an C-like enum implementing Drop)
 - rust-lang#72486 (Fix asinh of negative values)
 - rust-lang#72497 (tag/niche terminology cleanup)
 - rust-lang#72999 (Create self-contained directory and move there some of external binaries/libs)
 - rust-lang#73130 (Remove const prop for indirects)
 - rust-lang#73142 (Ensure std benchmarks get tested.)
 - rust-lang#73305 (Disallow loading crates with non-ascii identifier name.)
 - rust-lang#73346 (Add rust specific features to print target features)
 - rust-lang#73362 (Test that bounds checks are elided when slice len is checked up-front)
 - rust-lang#73459 (Reduce pointer casts in Box::into_boxed_slice)
 - rust-lang#73464 (Document format correction)
 - rust-lang#73479 (Minor tweaks to liballoc)

Failed merges:

r? @ghost
@bors bors merged commit 3b4bec2 into rust-lang:master Jun 19, 2020
@BlackHoleFox BlackHoleFox mentioned this pull request Aug 23, 2022
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Aug 23, 2022
@bors
Auto merge of #11017 - BlackHoleFox:non-ascii-names, r=weihanglo
6da7267 
Update non-ASCII crate name warning message

This PR fixes an outdated warning when initializing crates sometimes.

### What does this PR try to resolve?
Per [a Zulip convo](https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Non-ASCII.20crate.20name.20status/near/294876491) on the topic, non-ASCII crate names are no longer allowed on any toolchain since rust-lang/rust#73305, during the `non_ascii_idents` feature's development. Cargo however tells the user that they are accepted on Nightly. Rust and Cargo should agree on this point to avoid future confusion.

### How should we test and review this PR?
This should be covered by the existing test that was changed but if desired its easy to test with a checkout:

```
Running `/Users/fox/x/Forks/cargo/target/release/cargo init 'ああああ'`
warning: the name `ああああ` contains non-ASCII characters
Non-ASCII crate names are not supported by Rust.
```
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov Awaiting requested review from petrochenkov

Assignees

@petrochenkov petrochenkov

Labels

F-non_ascii_idents `#![feature(non_ascii_idents)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

7 participants

@crlf0710 @rust-highfive @petrochenkov @bors @RalfJung @cuviper @matthewjasper