Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #73289

Closed
wants to merge 31 commits into from

Commits on Jun 7, 2020

  1. Configuration menu
    Copy the full SHA
    5837518 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d684855 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5fdbbe View commit details
    Browse the repository at this point in the history
  4. Preserve expressions that get a DefId

    Namely closures and `async` blocks. We have to make a few modifications
    to closures to make them compile.
    ecstatic-morse committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    d8c99f3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1a30042 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e319f20 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Configuration menu
    Copy the full SHA
    687767a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c91320f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abf74b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50c422e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    17951e2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    19bb589 View commit details
    Browse the repository at this point in the history
  7. review comments: wording

    estebank committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    3cfecde View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bdfb9b1 View commit details
    Browse the repository at this point in the history
  9. Register new eror code

    estebank committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    215de3b View commit details
    Browse the repository at this point in the history
  10. small tweaks

    estebank committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    187e105 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    6145918 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c29b3fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7cde07e View commit details
    Browse the repository at this point in the history
  4. fix rebase

    estebank committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    03552ec View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Configuration menu
    Copy the full SHA
    57b54c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4bd180 View commit details
    Browse the repository at this point in the history
  3. Helper method for whether type has structural equality

    This helper method works for all types, falling back to a query for
    `TyKind::Adt`s to determine whether the implement the
    `{Partial,}StructuralEq` traits.
    ecstatic-morse committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    bd4bd59 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1dd4561 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2801761 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

    …atthewjasper
    
    On recursive ADT, provide indirection structured suggestion
    Dylan-DPC authored Jun 12, 2020
    Configuration menu
    Copy the full SHA
    c30ca41 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#72804 - estebank:opaque-missing-lts-in-fn-2…

    …, r=nikomatsakis
    
    Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position
    
    * Suggest substituting `'static` lifetime in impl/dyn `Trait + 'static` instead of `Trait + 'static + '_`
    * When `'static` is explicit, also suggest constraining argument with it
    * Reduce verbosity of suggestion message and mention lifetime in label
    * Tweak output for overlapping required/captured spans
    * Give these errors an error code
    
    Follow up to rust-lang#72543.
    
    r? @nikomatsakis
    Dylan-DPC authored Jun 12, 2020
    Configuration menu
    Copy the full SHA
    f27f659 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73066 - ecstatic-morse:query-structural-eq2…

    …, r=pnkfelix
    
    Querify whether a type has structural equality (Take 2)
    
    Alternative to rust-lang#72177.
    
    Unlike in rust-lang#72177, this helper method works for all types, falling back to a query for `TyKind::Adt`s that determines whether the `{Partial,}StructuralEq` traits are implemented.
    
    This is my preferred interface for this method. I think this is better than just documenting that the helper only works for ADTs. If others disagree, we can just merge rust-lang#72177 with the fixes applied. This has already taken far too long.
    Dylan-DPC authored Jun 12, 2020
    Configuration menu
    Copy the full SHA
    aeb8dd7 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73103 - ecstatic-morse:replace-body-with-lo…

    …op, r=pnkfelix
    
    Preserve `Expr`s that have `DefId`s in `ReplaceBodyWithLoop`
    
    This PR fixes the last part of rust-lang#71104 by preserving expressions that are assigned their own `DefId`s (closures and `async` blocks) when passing them to `rustdoc`. This avoids having a `DefId` without a corresponding `HirId`.
    
    The first commit in this PR makes `-Zunpretty=everybody_loops` actually work again, and the subsequent two are miscellaneous cleanup. They should probably get merged regardless of what we end up doing here.
    
    Sample input:
    ```rust
    fn foo() -> Box<i32> {
        let x = |a: i64| {
            const FOO: i64 = 1;
        };
    
        let a = 4;
        Box::new(a)
    }
    ```
    
    Sample output:
    ```rust
    fn foo() -> Box<i32> {
        || -> !
            {
                const FOO: i64 = 1;
                loop  { }
            };
        loop  { }
    }
    ```
    
    r? @ghost
    Dylan-DPC authored Jun 12, 2020
    Configuration menu
    Copy the full SHA
    e7a17c5 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73267 - ehuss:cargotest-this-cargo, r=Mark-…

    …Simulacrum
    
    Use the built cargo for cargotest.
    
    cargotest was using the beta (bootstrap) cargo. This changes it so that it will use the locally built cargo. This is intended to provide a sort of smoke test to ensure Cargo is functional. This *shouldn't* have any real impact on the CI build time.  The cargotest job also happens to run cargo's testsuite, so it should already be building cargo.
    
    Note: This will fail until rust-lang#73266 is merged.
    Dylan-DPC authored Jun 12, 2020
    Configuration menu
    Copy the full SHA
    77404e5 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#73277 - RalfJung:miri-caller-location, r=ol…

    …i-obk
    
    fix caller_location intrinsic for Miri
    
    Fixes rust-lang#73272
    
    r? @oli-obk Cc @Aaron1011
    Dylan-DPC authored Jun 12, 2020
    Configuration menu
    Copy the full SHA
    f6bb405 View commit details
    Browse the repository at this point in the history