Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple asm! options groups and report an error on duplicate options #73227

Merged
merged 20 commits into from
Jun 21, 2020
Merged

Allow multiple asm! options groups and report an error on duplicate options #73227

merged 20 commits into from
Jun 21, 2020

Commits on Jun 20, 2020

  1. Allow multiple asm! options

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    c883fa4 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    e614116 View commit details
    Browse the repository at this point in the history

  3. Use Vec<Span> instead of Option<Vec<Span>>

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    1d2acdf View commit details
    Browse the repository at this point in the history

  4. Clean up

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    27cc7c7 View commit details
    Browse the repository at this point in the history

  5. Add codegen test for multiple asm! options

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    820bba1 View commit details
    Browse the repository at this point in the history

  6. Warn on duplicate asm! options

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    2be403c View commit details
    Browse the repository at this point in the history

  7. Add UI test for duplicate asm! options warning

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    7aaadb6 View commit details
    Browse the repository at this point in the history

  8. Make warning an error; use help instead of suggestion; clean up code 

    For some reason, the help message is now in a separate message, which
adds a lot of noise. I would like to try to get it back to one message.
    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    b94b7e7 View commit details
    Browse the repository at this point in the history

  9. Use span_label

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    ac54265 View commit details
    Browse the repository at this point in the history

  10. Update duplicate options test

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    7c5b66f View commit details
    Browse the repository at this point in the history

  11. Get option name from symbol instead of snippet

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    c7da50d View commit details
    Browse the repository at this point in the history

  12. Use bitflags function instead of custom one

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    e8be797 View commit details
    Browse the repository at this point in the history

  13. Use span_suggestion instead of span_label

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    b00b1a4 View commit details
    Browse the repository at this point in the history

  14. Add more to duplicate options test

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    f4dfc61 View commit details
    Browse the repository at this point in the history

  15. Make suggestion machine-applicable

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    4ba6697 View commit details
    Browse the repository at this point in the history

  16. Create a separate, tool-only suggestion for the comma 

    That way the comma isn't highlighted as part of the option in the UI.

Weirdly, the comma removal suggestion shows up in the UI.
    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    8fe6710 View commit details
    Browse the repository at this point in the history

  17. Add documentation

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    db9d376 View commit details
    Browse the repository at this point in the history

  18. Use p.token instead of p.look_ahead()

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    58f812b View commit details
    Browse the repository at this point in the history

  19. Fix duplicate options error 

    The UI isn't glitching anymore.
    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    8d80cc5 View commit details
    Browse the repository at this point in the history

  20. Run ./x.py fmt

    @camelid
    camelid committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    c31785a View commit details
    Browse the repository at this point in the history