Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Sort E0408 errors by Symbol str #72982

Merged
merged 2 commits into from
Jun 5, 2020
Merged

resolve: Sort E0408 errors by Symbol str #72982

merged 2 commits into from
Jun 5, 2020

Commits on Jun 4, 2020

  1. test: ui: skip tests which aren't appropriate for RISC-V

    @tblah
    tblah committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    8edb05c View commit details
    Browse the repository at this point in the history

  2. resolve: Sort E0408 errors by Symbol str 

    Previously errors were sorted by Symbol index instead of the string. The
indexes are not the same between architectures because Symbols for
architecture extensions (e.g. x86 AVX or RISC-V d) are interned before
the source file is parsed. RISC-V's naming of extensions after single
letters led to it having errors sorted differently for test cases using
single letter variable names. Instead sort the errors by the Symbol
string so that it is stable across architectures.
    @tblah
    tblah committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    41bfd18 View commit details
    Browse the repository at this point in the history