rustc: Remove the --passive-segments LLD flag on wasm
#72889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag looks like it's been removed in LLVM 10, so this removes rustc unconditionally passing the flag.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 0fd9a37 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 1, 2020
…=nikomatsakis rustc: Remove the `--passive-segments` LLD flag on wasm This flag looks like it's been removed in LLVM 10, so this removes rustc unconditionally passing the flag.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#72775 (Return early to avoid ICE) - rust-lang#72795 (Add a test for `$:ident` in proc macro input) - rust-lang#72822 (remove trivial calls to mk_const) - rust-lang#72825 (Clarify errors and warnings about the transition to the new asm!) - rust-lang#72827 (changed *nix to Unix-like) - rust-lang#72880 (Clean up E0637 explanation) - rust-lang#72886 (Remove allow missing_debug_implementations for MaybeUninit) - rust-lang#72889 (rustc: Remove the `--passive-segments` LLD flag on wasm) - rust-lang#72891 (Add associated consts MIN/MAX for Wrapping<Int>) - rust-lang#72893 (test miri-unleash TLS accesses) Failed merges: r? @ghost
sunfishcode
added a commit
to sunfishcode/rust
that referenced
this pull request
Sep 28, 2022
Since rust-lang#72889, the Rust wasm target doesn't use --passive-segments, so remove the `--export=__wasm_init_memory`. As documented in the [tool-conventions Linking convention], `__wasm_init_memory` is not intended to be exported. [tool-conventions Linking convention]: https://github.com/WebAssembly/tool-conventions/blob/7c064f304858f67ebf22964a84b7e9658e29557a/Linking.md#shared-memory-and-passive-segments
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Sep 29, 2022
…it-memory, r=nagisa Don't export `__wasm_init_memory` on WebAssembly. Since rust-lang#72889, the Rust wasm target doesn't use --passive-segments, so remove the `--export=__wasm_init_memory`. As documented in the [tool-conventions Linking convention], `__wasm_init_memory` is not intended to be exported. [tool-conventions Linking convention]: https://github.com/WebAssembly/tool-conventions/blob/7c064f304858f67ebf22964a84b7e9658e29557a/Linking.md#shared-memory-and-passive-segments
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Sep 29, 2022
…it-memory, r=nagisa Don't export `__wasm_init_memory` on WebAssembly. Since rust-lang#72889, the Rust wasm target doesn't use --passive-segments, so remove the `--export=__wasm_init_memory`. As documented in the [tool-conventions Linking convention], `__wasm_init_memory` is not intended to be exported. [tool-conventions Linking convention]: https://github.com/WebAssembly/tool-conventions/blob/7c064f304858f67ebf22964a84b7e9658e29557a/Linking.md#shared-memory-and-passive-segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag looks like it's been removed in LLVM 10, so this removes rustc
unconditionally passing the flag.