- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
fix discriminant_value sign extension #72425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | FWIW, #72419 will make this obsolete, but I did not want to block Miri on landing that larger PR. | 
      
     Merged
  
    
  bors 
      added a commit
        to rust-lang/miri
      that referenced
      this pull request
    
      May 21, 2020 
    
    
      
  
    
      
    
  
rustup No changes needed -- but the next bump is blocked on rust-lang/rust#72425.
              
                    nikomatsakis
  
              
              approved these changes
              
                  
                    May 21, 2020 
                  
              
              
            
            
| @bors r+ | 
| 📌 Commit 16e8c013b9d10939777527f521481a2875d5f7d1 has been approved by  | 
| @bors r=nikomatsakis | 
| 📌 Commit 94aa028 has been approved by  | 
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      May 21, 2020 
    
    
      
  
    
      
    
  
…akis fix discriminant_value sign extension Fixes a regression introduced in rust-lang#70705 r? @nikomatsakis Cc @lcnr @oli-obk
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      May 21, 2020 
    
    
      
  
    
      
    
  
…akis fix discriminant_value sign extension Fixes a regression introduced in rust-lang#70705 r? @nikomatsakis Cc @lcnr @oli-obk
  This was referenced May 21, 2020 
      
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      May 21, 2020 
    
    
      
  
    
      
    
  
Rollup of 7 pull requests Successful merges: - rust-lang#72055 (Intern predicates) - rust-lang#72149 (Don't `type_of` on trait assoc ty without default) - rust-lang#72347 (Make intra-link resolve links for both trait and impl items) - rust-lang#72350 (Improve documentation of `slice::from_raw_parts`) - rust-lang#72382 (Show default values for debug-assertions & debug-assertions-std) - rust-lang#72421 (Fix anchor display when hovering impl) - rust-lang#72425 (fix discriminant_value sign extension) Failed merges: r? @ghost
      
     Merged
  
    
  bors 
      added a commit
        to rust-lang/miri
      that referenced
      this pull request
    
      May 22, 2020 
    
    
      
  
    
      
    
  
rustup Make sure that rust-lang/rust#72425 helped
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes a regression introduced in #70705
r? @nikomatsakis Cc @lcnr @oli-obk