Skip to content

Conversation

RalfJung
Copy link
Member

Fixes a regression introduced in #70705
r? @nikomatsakis Cc @lcnr @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2020
@RalfJung
Copy link
Member Author

FWIW, #72419 will make this obsolete, but I did not want to block Miri on landing that larger PR.

@RalfJung RalfJung mentioned this pull request May 21, 2020
bors added a commit to rust-lang/miri that referenced this pull request May 21, 2020
rustup

No changes needed -- but the next bump is blocked on rust-lang/rust#72425.
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 21, 2020

📌 Commit 16e8c013b9d10939777527f521481a2875d5f7d1 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2020
@RalfJung
Copy link
Member Author

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented May 21, 2020

📌 Commit 94aa028 has been approved by nikomatsakis

RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
…akis

fix discriminant_value sign extension

Fixes a regression introduced in rust-lang#70705
r? @nikomatsakis Cc @lcnr @oli-obk
RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
…akis

fix discriminant_value sign extension

Fixes a regression introduced in rust-lang#70705
r? @nikomatsakis Cc @lcnr @oli-obk
This was referenced May 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#72055 (Intern predicates)
 - rust-lang#72149 (Don't `type_of` on trait assoc ty without default)
 - rust-lang#72347 (Make intra-link resolve links for both trait and impl items)
 - rust-lang#72350 (Improve documentation of `slice::from_raw_parts`)
 - rust-lang#72382 (Show default values for debug-assertions & debug-assertions-std)
 - rust-lang#72421 (Fix anchor display when hovering impl)
 - rust-lang#72425 (fix discriminant_value sign extension)

Failed merges:

r? @ghost
@bors bors merged commit 74b5c50 into rust-lang:master May 22, 2020
@RalfJung RalfJung mentioned this pull request May 22, 2020
bors added a commit to rust-lang/miri that referenced this pull request May 22, 2020
@RalfJung RalfJung deleted the discr-sign-ext branch May 22, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants