Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miri read_discriminant: return a scalar instead of raw underlying bytes #72419

Merged
merged 7 commits into from
May 30, 2020
Merged

Miri read_discriminant: return a scalar instead of raw underlying bytes #72419

merged 7 commits into from
May 30, 2020
+129 −94

Commits on May 25, 2020

  1. Miri: refactor read_discriminant and make it return Scalar

    @RalfJung
    RalfJung committed May 25, 2020
    Configuration menu
    Copy the full SHA
    0f18203 View commit details
    Browse the repository at this point in the history

  2. comments and refactor variable names

    @RalfJung
    RalfJung committed May 25, 2020
    Configuration menu
    Copy the full SHA
    5a3971c View commit details
    Browse the repository at this point in the history

  3. assert that types without discriminant use variant idx of 0

    @RalfJung
    RalfJung committed May 25, 2020
    Configuration menu
    Copy the full SHA
    f8f8033 View commit details
    Browse the repository at this point in the history

  4. Format and more tracing

    @RalfJung
    RalfJung committed May 25, 2020
    Configuration menu
    Copy the full SHA
    d94923e View commit details
    Browse the repository at this point in the history

  5. Add helper method for determining the type of a discriminant

    @RalfJung
    RalfJung committed May 25, 2020
    Configuration menu
    Copy the full SHA
    64fbe2f View commit details
    Browse the repository at this point in the history

  6. fix discriminant_ty for non-enums

    @RalfJung
    RalfJung committed May 25, 2020
    Configuration menu
    Copy the full SHA
    ad7179d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. more type sanity checks in Miri

    @RalfJung
    RalfJung committed May 29, 2020
    Configuration menu
    Copy the full SHA
    c4b6224 View commit details
    Browse the repository at this point in the history