[WIP] Implement shim for types that transitively derive Clone #72409

Aaron1011 · 2020-05-21T02:04:16Z

If a type is #[derive(Clone)], and all of its transitive fields
are also #[derive(Clone)], we skip generating the actual clone
function. Instead, we generate a 'clone shim', which just acts like the
trivial Clone impl for a Copy type. We do this even if the type
itself is not Copy.

If a type is `#[derive(Clone)]`, and all of its transitive fields are also `#[derive(Clone)]`, we skip generating the actual `clone` function. Instead, we generate a 'clone shim', which just acts like the trivial `Clone` impl for a `Copy` type. We do this even if the type itself is not `Copy`.

rust-highfive · 2020-05-21T02:04:19Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

Aaron1011 · 2020-05-21T02:04:25Z

@bors try @rust-timer queue

rust-timer · 2020-05-21T02:04:26Z

Awaiting bors try build completion

bors · 2020-05-21T02:04:37Z

⌛ Trying commit c5f81d3 with merge c5fabb124ddbb26acecd838a51e410b4e1ea16e4...

rust-highfive · 2020-05-21T03:14:54Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 2'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200512.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200512.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.2)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/f339c82c-ce8d-4ed9-b85c-61f1287e2ba7.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72409/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72409/merge:refs/remotes/pull/72409/merge
---
 ---> 3adb0605cc65
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 ---> Using cache
 ---> 28dbc326cb7f
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            python3 ../x.py doc --stage 0 src/libstd &&            /scripts/validate-toolstate.sh
 ---> 537a01811900
Successfully built 537a01811900
Successfully tagged rust-ci:latest
Built container sha256:537a018119009dc218456238dec90b5530050db1e2a1e166550c218003f6159d
---
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking chalk-solve v0.10.0
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
configure: rust.verify-llvm-ir  := True
configure: llvm.assertions      := True
configure: llvm.ccache          := sccache
configure: build.submodules     := False
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Hugepagesize:       2048 kB
DirectMap4k:      118720 kB
DirectMap2M:     4075520 kB
DirectMap1G:     5242880 kB
+ python3 ../x.py test src/tools/expand-yaml-anchors
Ensuring the YAML anchors in the GitHub Actions config were expanded
Ensuring the YAML anchors in the GitHub Actions config were expanded
Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.11
   Compiling linked-hash-map v0.5.2
   Compiling lazy_static v1.4.0
   Compiling lazy_static v1.4.0
   Compiling yaml-rust v0.4.3
   Compiling quote v1.0.2
   Compiling thiserror-impl v1.0.5
   Compiling thiserror v1.0.5
   Compiling yaml-merge-keys v0.4.0
   Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
Build completed successfully in 0:00:33
+ python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
    Finished dev [unoptimized] target(s) in 0.24s
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_session v0.0.0 (/checkout/src/librustc_session)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
    Checking rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
---
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/src/librustc_ty/instance.rs at line 97:
                 let self_ty = trait_ref.self_ty();
                 if name == sym::clone {
                     if tcx.is_transitive_derive_clone(self_ty) {
-                        debug!("Using CloneShim for transitive Clone derive on {:?}",
-                               self_ty);
+                        debug!("Using CloneShim for transitive Clone derive on {:?}", self_ty);
                         return Ok(Some(Instance {
                             def: ty::InstanceDef::CloneShim(def_id, self_ty, true),
                             substs: rcvr_substs,
Diff in /checkout/src/librustc_ty/instance.rs at line 105:
+                        }));
                     }
                 }
             }
             }
Diff in /checkout/src/librustc_ty/instance.rs at line 109:
-
 
             let trait_def_id = tcx.trait_id_of_impl(impl_data.impl_def_id).unwrap();
             let trait_def = tcx.trait_def(trait_def_id);
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustc_ty/instance.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
Build completed unsuccessfully in 0:00:43
== clock drift check ==
  local time: Thu May 21 02:27:46 UTC 2020
  network time: Thu, 21 May 2020 02:27:46 GMT
  network time: Thu, 21 May 2020 02:27:46 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72409/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72409/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3479) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-05-21T04:27:46Z

☀️ Try build successful - checks-azure
Build commit: c5fabb124ddbb26acecd838a51e410b4e1ea16e4 (c5fabb124ddbb26acecd838a51e410b4e1ea16e4)

rust-timer · 2020-05-21T04:27:47Z

Queued c5fabb124ddbb26acecd838a51e410b4e1ea16e4 with parent 0aa6751, future comparison URL.

rust-timer · 2020-05-21T07:36:35Z

Finished benchmarking try commit c5fabb124ddbb26acecd838a51e410b4e1ea16e4, comparison URL.

crlf0710 · 2020-05-30T00:33:21Z

Needs to rebase and fix the CI failure.

varkor · 2020-05-30T13:42:33Z

Was the expectation that this would improve performance, or is there a different motivation?

Aaron1011 · 2020-05-30T14:01:57Z

@varkor: I opened this as an experiment to measure the perf impact - however, it doesn't seem that optimization is very useful in practice (at least where compilation time is concerned).

Aaron1011 · 2020-06-01T04:19:07Z

I'm closing this for now. I may revisit it at some point if I come up with a way to speed it up.

rust-highfive assigned varkor May 21, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2020

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2020

Aaron1011 closed this Jun 1, 2020

Aaron1011 mentioned this pull request Mar 16, 2021

remove redundant clones via mir opt? #83193

Open

Aaron1011 mentioned this pull request Jun 27, 2021

Derive Copy for VarianceDiagInfo #86670

Merged

Aaron1011 mentioned this pull request Jan 28, 2022

Clarify that RFC1520 does not permit the compiler to replace calls to Clone::clone with a memcpy rust-lang/rfcs#3197

Open

Aaron1011 mentioned this pull request Feb 10, 2023

Clone "copyables" using copy codegen rust-lang/compiler-team#588

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Implement shim for types that transitively derive Clone #72409

[WIP] Implement shim for types that transitively derive Clone #72409

Uh oh!

Aaron1011 commented May 21, 2020

Uh oh!

rust-highfive commented May 21, 2020

Uh oh!

Aaron1011 commented May 21, 2020

Uh oh!

rust-timer commented May 21, 2020

Uh oh!

bors commented May 21, 2020

Uh oh!

rust-highfive commented May 21, 2020

Uh oh!

bors commented May 21, 2020

Uh oh!

rust-timer commented May 21, 2020

Uh oh!

rust-timer commented May 21, 2020

Uh oh!

crlf0710 commented May 30, 2020

Uh oh!

varkor commented May 30, 2020

Uh oh!

Aaron1011 commented May 30, 2020 •

edited

Loading

Uh oh!

Aaron1011 commented Jun 1, 2020

Uh oh!

Uh oh!

[WIP] Implement shim for types that transitively derive Clone #72409

[WIP] Implement shim for types that transitively derive Clone #72409

Uh oh!

Conversation

Aaron1011 commented May 21, 2020

Uh oh!

rust-highfive commented May 21, 2020

Uh oh!

Aaron1011 commented May 21, 2020

Uh oh!

rust-timer commented May 21, 2020

Uh oh!

bors commented May 21, 2020

Uh oh!

rust-highfive commented May 21, 2020

Uh oh!

bors commented May 21, 2020

Uh oh!

rust-timer commented May 21, 2020

Uh oh!

rust-timer commented May 21, 2020

Uh oh!

crlf0710 commented May 30, 2020

Uh oh!

varkor commented May 30, 2020

Uh oh!

Aaron1011 commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aaron1011 commented Jun 1, 2020

Uh oh!

Uh oh!

Aaron1011 commented May 30, 2020 •

edited

Loading