Add command aliases from Cargo to x.py commands #71905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'm not opposed to this though not really a fan myself, but it's a minimal patch set so @bors r+ rollup |
|
📌 Commit b83853d has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 5, 2020
…crum Add command aliases from Cargo to x.py commands Fixes rust-lang#71357
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 5, 2020
…crum Add command aliases from Cargo to x.py commands Fixes rust-lang#71357
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 5, 2020
…crum Add command aliases from Cargo to x.py commands Fixes rust-lang#71357
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 5, 2020
…crum Add command aliases from Cargo to x.py commands Fixes rust-lang#71357
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#71510 (Btreemap iter intertwined) - rust-lang#71727 (SipHasher with keys initialized to 0 should just use new()) - rust-lang#71889 (Explain our RwLock implementation) - rust-lang#71905 (Add command aliases from Cargo to x.py commands) - rust-lang#71914 (Backport 1.43.1 release notes to master) - rust-lang#71921 (explain the types used in the open64 call) Failed merges: r? @ghost
pickfire
reviewed
May 8, 2020
| @@ -106,18 +106,18 @@ impl Flags { | |||
| Usage: x.py <subcommand> [options] [<paths>...] | |||
|
|
|||
| Subcommands: | |||
| build Compile either the compiler or libraries | |||
| check Compile either the compiler or libraries, using cargo check | |||
| build, b Compile either the compiler or libraries | |||
There was a problem hiding this comment.
Doesn't cargo does not have the additional , b?
There was a problem hiding this comment.
No, it doesn't, but I think it should. I added it to promote discoverability.
There was a problem hiding this comment.
I think we can promote discoverability with (b)uild too.
There was a problem hiding this comment.
No, it doesn't, but I think it should. I added it to promote discoverability.
Let me go add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71357