Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add needs_substs check to check_binary_op. #71386

Closed
wants to merge 5 commits into from
Closed

Add needs_substs check to check_binary_op. #71386

wants to merge 5 commits into from

Commits on Apr 21, 2020

  1. Also catch rust-lang#71353

    @jumbatm
    jumbatm committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    32ff9a0 View commit details
    Browse the repository at this point in the history

  2. Skip check_binary_op if rhs needs substs.

    @jumbatm
    jumbatm committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    c61c17c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Also add substs check before evaluating for lhs.

    @jumbatm
    jumbatm committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    cf3b744 View commit details
    Browse the repository at this point in the history

  2. Also add substs check to check_unary_op.

    @jumbatm
    jumbatm committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2d25b2b View commit details
    Browse the repository at this point in the history

  3. Explain check_{unary,binary}_op needs-substs behaviour.

    @jumbatm
    jumbatm committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2e6fab9 View commit details
    Browse the repository at this point in the history