Rollup of 6 pull requests #71059
Merged
Rollup of 6 pull requests #71059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustc_session exports it for other crates to avoid mismatching crate versions.
The code was broken because it printed "llvm-config" instead of the absolute path to the llvm-config executable, causing Cargo to always rebuild librustc_llvm if using system LLVM. Also, it's not the build system's job to rebuild when a system library changes, so we simply don't emit "rerun-if-changed" if a path to LLVM was not explicitly provided.
x.py sets it unconditionally, so want it for plain "cargo build". We need to load one of the panic runtimes that is in src (vs. pre-built in the compiler's sysroot) to ensure that we don't load libpanic_unwind from the sysroot. That would lead to a load of libcore, also from the sysroot, and create lots of errors about duplicate lang items.
The compiler normalizes source when reading files initially (removes BOMs, etc), but not when loading external sources. Fixes rust-lang#70874 by normalizing when loading external sources too. Adds a test to verify normalization.
I was looking into improving some Clippy documentation but was missing a place that explains the `kw` and `sym` modules from rustc.
…-Simulacrum Partial work on building with Cargo This cherry picks the commits I'm directly approving from rust-lang#70999, I want to land them so that that PR is smaller.
…an-DPC Clean up E0515 explanation r? @Dylan-DPC
…schievink Update links of `rustc guide` Picks up the things we left behind in the transition, hopefully they're last ones. r? @spastorino
Normalize source when loading external foreign source into SourceMap The compiler normalizes source when reading files initially (removes BOMs, etc), but not when loading external sources. This leads to the external source matching according to the `src_hash`, but differing internally because it was not normalized. Fixes rust-lang#70874.
…-DPC Add some basic docs to `sym` and `kw` modules I was looking into improving some Clippy documentation but was missing a place that explains the `kw` and `sym` modules from rustc. This adds some very basic usage documentation to these modules.
…an-DPC Clean up E0516 explanation r? @Dylan-DPC
|
@bors r+ rollup=never p=6 |
|
📌 Commit e684630 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e684630 with merge 2398e5a0466495a8abb20962a0a62f1b64093b13... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
spurious @bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced Apr 12, 2020
|
📣 Toolstate changed by #71059! Tested on commit 3712e11. 💔 rls on windows: test-pass → build-fail (cc @Xanewok). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 12, 2020
Tested on commit rust-lang/rust@3712e11. Direct link to PR: <rust-lang/rust#71059> 💔 rls on windows: test-pass → build-fail (cc @Xanewok). 💔 rls on linux: test-pass → build-fail (cc @Xanewok). 💔 rustfmt on windows: test-pass → build-fail (cc @topecongiro). 💔 rustfmt on linux: test-pass → build-fail (cc @topecongiro).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc guide#71041 (Update links ofrustc guide)symandkwmodules #71053 (Add some basic docs tosymandkwmodules)Failed merges:
r? @ghost