-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove the call that makes miri fail #70038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
57b1e7a
Remove the call that makes miri fail
DutchGhost dcc2321
The const_forget_box was unused, and doesns't add anything to test by…
DutchGhost 0760803
rather than removing const_forget_box, stick an attribute on it and e…
DutchGhost 4c363e3
Move the const-forget test into ui tests
DutchGhost d6f3a43
Update const_forget.rs
DutchGhost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// check-pass | ||
|
||
#![feature(const_forget)] | ||
|
||
use std::mem::forget; | ||
|
||
const _: () = forget(0i32); | ||
const _: () = forget(Vec::<Vec<Box<i32>>>::new()); | ||
|
||
// Writing this function signature without const-forget | ||
// triggers compiler errors: | ||
// 1) That we use a non-const fn inside a const fn | ||
// 2) without the forget, it complains about the destructor of Box | ||
// | ||
// FIXME: this method cannot be called in const-eval yet, as Box isn't | ||
// const constructable | ||
#[allow(unused)] | ||
const fn const_forget_box<T: ?Sized>(b: Box<T>) { | ||
forget(b); | ||
} | ||
|
||
fn main() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.