Skip to content

Rollup of 4 pull requests #67866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 4, 2020
Merged

Rollup of 4 pull requests #67866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e4886d
Revert `const_err` lint checking of casts
wesleywiser Jan 3, 2020
e589358
improve generic `Drop` error messages
euclio Jan 3, 2020
e9990bc
clarify that `Drop` can be implemented for enums and unions too
euclio Jan 3, 2020
ec64bbb
Small error explanations cleanup
GuillaumeGomez Jan 3, 2020
aab4276
Clean up E0164 explanation
GuillaumeGomez Jan 3, 2020
83333fe
Remove unused `#[link_name = "m"]` attributes
ollie27 Jan 3, 2020
062cd78
Update E0164.md
Dylan-DPC Jan 4, 2020
a469b17
Rollup merge of #67822 - wesleywiser:revert_67676, r=oli-obk
GuillaumeGomez Jan 4, 2020
1140cee
Rollup merge of #67823 - euclio:drop-improvements, r=petrochenkov
GuillaumeGomez Jan 4, 2020
5c73be1
Rollup merge of #67837 - GuillaumeGomez:clean-up-err-codes, r=Dylan-DPC
GuillaumeGomez Jan 4, 2020
a86a189
Rollup merge of #67848 - ollie27:float_link_name_attr, r=Dylan-DPC
GuillaumeGomez Jan 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused #[link_name = "m"] attributes 
These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway.
  • Loading branch information
@ollie27
ollie27 committed Jan 3, 2020
commit 83333fe85b25c77f35b79bf06cde69b889558dca
1 change: 0 additions & 1 deletion src/libstd/sys/unix/cmath.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use libc::{c_double, c_float};

#[link_name = "m"]
extern "C" {
pub fn acos(n: c_double) -> c_double;
pub fn acosf(n: c_float) -> c_float;
Expand Down
1 change: 0 additions & 1 deletion src/libstd/sys/vxworks/cmath.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use libc::{c_double, c_float};

#[link_name = "m"]
extern "C" {
pub fn acos(n: c_double) -> c_double;
pub fn acosf(n: c_float) -> c_float;
Expand Down
1 change: 0 additions & 1 deletion src/libstd/sys/windows/cmath.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use libc::{c_double, c_float};

#[link_name = "m"]
extern "C" {
pub fn acos(n: c_double) -> c_double;
pub fn asin(n: c_double) -> c_double;
Expand Down