Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MIR lowering for or-patterns #67668

Merged
merged 13 commits into from
Feb 4, 2020
Merged

Implement MIR lowering for or-patterns #67668

merged 13 commits into from
Feb 4, 2020

Commits on Feb 1, 2020

  1. Remove or_patterns from INCOMPLETE_FEATURES

    @matthewjasper
    matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    425e494 View commit details
    Browse the repository at this point in the history

  2. Generate prebinding blocks lazily

    @matthewjasper
    matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    eecee76 View commit details
    Browse the repository at this point in the history

  3. Don't create unnecessary block

    @matthewjasper
    matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    64eab77 View commit details
    Browse the repository at this point in the history

  4. Implement general or-patterns in match expressions

    @matthewjasper
    matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    5cc4352 View commit details
    Browse the repository at this point in the history

  5. Implement general or-patterns in let statements

    @matthewjasper
    matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    a20969c View commit details
    Browse the repository at this point in the history

  6. Update existing tests for or-patterns

    @matthewjasper
    matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    30058df View commit details
    Browse the repository at this point in the history

  7. Basic run-pass tests for or-patterns 

    Add some basic run-pass ui tests for or-patterns.
    @dlrobertson @matthewjasper
    dlrobertson authored and matthewjasper committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    0b1ff27 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. Add more tests for or-patterns

    @matthewjasper
    matthewjasper committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    c7e6f88 View commit details
    Browse the repository at this point in the history

  2. Make Candidate private

    @matthewjasper
    matthewjasper committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    5f90dbd View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @matthewjasper
    matthewjasper committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    89e52e2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @matthewjasper @Centril
    matthewjasper and Centril committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    1d90ed6 View commit details
    Browse the repository at this point in the history

  5. Make use of Place: Copy

    @matthewjasper
    matthewjasper committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    9b9dafb View commit details
    Browse the repository at this point in the history

  6. Avoid scheduling repeated StorageDeads 

    Also add some comments
    @matthewjasper
    matthewjasper committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    8dbbe4d View commit details
    Browse the repository at this point in the history