Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coerce_inner: use initial expected_ty #67278

Merged
merged 1 commit into from
Dec 13, 2019
Merged

coerce_inner: use initial expected_ty #67278

merged 1 commit into from
Dec 13, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Dec 13, 2019

Fixes #67273.
Follow-up to #59439.

r? @oli-obk

@Centril Centril added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2019
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2019
@nikomatsakis nikomatsakis removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 13, 2019
@nikomatsakis
Copy link
Contributor

Decided against backport in the design meeting today on the basis that this had not yet landed and didn't seem sufficiently urgent to make an exception.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 13, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 13, 2019

📌 Commit f97c37f has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 13, 2019
`coerce_inner`: use initial `expected_ty`

Fixes rust-lang#67273.
Follow-up to rust-lang#59439.

r? @oli-obk
bors added a commit that referenced this pull request Dec 13, 2019
Rollup of 7 pull requests

Successful merges:

 - #67026 (Improve diagnostics and code for exhaustiveness of empty matches)
 - #67235 (VecDeque: drop remaining items on destructor panic)
 - #67254 (dont ICE in case of invalid drop fn)
 - #67256 (Reduce allocs for validation errors)
 - #67274 (be explicit that mem::uninitialized is the same as MaybeUninit::uninit().assume_init())
 - #67278 (`coerce_inner`: use initial `expected_ty`)
 - #67280 (docs: std::convert::From: Fix typo)

Failed merges:

r? @ghost
@bors bors merged commit f97c37f into rust-lang:master Dec 13, 2019
@Centril Centril deleted the 67273 branch December 13, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE when match arms have incompatible types
5 participants