Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline some common methods on OsStr #67169

Merged
merged 1 commit into from
Dec 10, 2019
Merged

inline some common methods on OsStr #67169

merged 1 commit into from
Dec 10, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Dec 9, 2019 •
edited
Loading

Closes #67150

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2019
@tesuji tesuji mentioned this pull request Dec 9, 2019
Closed
@tesuji tesuji changed the title inline some common methods on OsSstr inline some common methods on OsStr Dec 9, 2019
@nagisa
Copy link
Member

nagisa commented Dec 9, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 9, 2019

📌 Commit bf1f1c2 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Dec 9, 2019
@tmandry
Rollup merge of rust-lang#67169 - lzutao:inline_osstr, r=nagisa
c255815 
inline some common methods on OsStr

Closes rust-lang#67150
@tmandry tmandry mentioned this pull request Dec 9, 2019
Merged
bors added a commit that referenced this pull request Dec 10, 2019
@bors
Auto merge of #67184 - tmandry:rollup-mzqxtck, r=tmandry
975e83a 
Rollup of 11 pull requests

Successful merges:

 - #66892 (Format libcore with rustfmt (including tests and benches))
 - #67106 (resolve: Resolve visibilities on fields with non-builtin attributes)
 - #67113 (Print the visibility in `print_variant`.)
 - #67115 (Simplify `check_decl_no_pat`.)
 - #67119 (libstd miri tests: avoid warnings)
 - #67125 (Added ExactSizeIterator bound to return types)
 - #67138 (Simplify `Layout::extend_packed`)
 - #67145 (fix miri step debug printing)
 - #67149 (Do not ICE #67123)
 - #67155 (Move `Layout`s instead of binding by reference)
 - #67169 (inline some common methods on OsStr)

Failed merges:

r? @ghost
@bors bors merged commit bf1f1c2 into rust-lang:master Dec 10, 2019
@tesuji tesuji deleted the inline_osstr branch December 10, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missed optimization because of missing inline attr on OsStr
4 participants
@tesuji @nagisa @bors @rust-highfive