Organize intrinsics promotion checks #66275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
spastorino
reviewed
Nov 11, 2019
RalfJung
reviewed
Nov 13, 2019
RalfJung
reviewed
Nov 13, 2019
RalfJung
reviewed
Nov 13, 2019
RalfJung
reviewed
Nov 13, 2019
RalfJung
reviewed
Nov 13, 2019
RalfJung
reviewed
Nov 13, 2019
src/test/ui/consts/const-eval/const-eval-intrinsic-promotion.rs
Outdated
Show resolved
Hide resolved
oli-obk
force-pushed
the
organize-intrinsics-promotion-checks
branch
from
bb353a0 to
22bef04
Compare
RalfJung
reviewed
Nov 16, 2019
This comment has been minimized.
This comment has been minimized.
RalfJung
added
S-waiting-on-author
oli-obk
force-pushed
the
organize-intrinsics-promotion-checks
branch
from
22bef04 to
9d30d2f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Nov 25, 2019
RalfJung
reviewed
Nov 25, 2019
oli-obk
force-pushed
the
organize-intrinsics-promotion-checks
branch
from
9d30d2f to
0bde1ad
Compare
RalfJung
reviewed
Nov 26, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Nov 27, 2019
RalfJung
reviewed
Nov 27, 2019
src/test/ui/consts/const-extern-fn/const-extern-fn-call-extern-fn.rs
Outdated
Show resolved
Hide resolved
|
The code LGTM, but please add some more comments as indicated in my comments above. |
oli-obk
force-pushed
the
organize-intrinsics-promotion-checks
branch
from
ba051bc to
0e30674
Compare
RalfJung
reviewed
Nov 28, 2019
Certainly not in this PR, this just fixes our existing checks.
They are both already implemented in Miri, so this is just a matter of moving that implementation into rustc. The main issue here is that these are unsafe, and we are currently not yet willing to provide unsafe operations in |
oli-obk
force-pushed
the
organize-intrinsics-promotion-checks
branch
from
85f8d4c to
e2bbf06
Compare
|
rebased and added FIXME @bors r=RalfJung |
|
📌 Commit 5cef094 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 4, 2019
…r=RalfJung Organize intrinsics promotion checks cc @vertexclique supersedes #61835 r? @RalfJung
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Dec 4, 2019
Tested on commit rust-lang/rust@7fa0465. Direct link to PR: <rust-lang/rust#66275> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
|
Ah dang, we finally got Miri in shape for the next nightly... |
9999years
added a commit
to 9999years/rust
that referenced
this pull request
Dec 19, 2019
Most of these have to be deleted; the various power_of_two functions use `intrinsics::ctlz_nonzero` internally, so they can't be made const before rust-lang#66275 is merged.
9999years
added a commit
to 9999years/rust
that referenced
this pull request
Dec 19, 2019
Most of the tests had to be deleted; the various power_of_two functions use `intrinsics::ctlz_nonzero` internally, so they can't be made const before rust-lang#66275 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vertexclique
supersedes #61835
r? @RalfJung