- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Rollup of 5 pull requests #66189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Rollup of 5 pull requests #66189
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Have tidy ensure that we document all `unsafe` blocks in libcore cc @rust-lang/libs I documented a few and added ignore flags on the other files. We can incrementally document the files, but won't regress any files this way.
…, r=kinnison [rustdoc] add sub settings This PR is to give a finer control over what types are automatically expanded or not as well as the possibility to add sub-settings in the settings page.  r? @Mark-Simulacrum
syntax: move stuff around Part of rust-lang#65324. r? @davidtwco cc @estebank @petrochenkov
Update some build-pass ui tests to use check-pass where applicable Helps with issue rust-lang#62277.
invalid_value lint: fix help text Now that we also warn about `MaybUninit::uninit().assume_init()`, just telling people "use `MaybeUninit`" isn't always sufficient. And anyway this seems like an important enough point to mention it here.
| @bors r+ p=5 rollup=never | 
| 📌 Commit 333899a has been approved by  | 
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Nov 7, 2019 
    
    
      
  
    
      
    
  
Rollup of 5 pull requests Successful merges: - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore) - #64696 ([rustdoc] add sub settings) - #65916 (syntax: move stuff around) - #66087 (Update some build-pass ui tests to use check-pass where applicable) - #66182 (invalid_value lint: fix help text) Failed merges: r? @ghost
| 💥 Test timed out | 
| @bors retry | 
| ⌛ Testing commit 333899a with merge b3909b9022886b13ab9883e445c831307c3a76f5... | 
| 💥 Test timed out | 
| @bors retry | 
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Nov 7, 2019 
    
    
      
  
    
      
    
  
Rollup of 5 pull requests Successful merges: - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore) - #64696 ([rustdoc] add sub settings) - #65916 (syntax: move stuff around) - #66087 (Update some build-pass ui tests to use check-pass where applicable) - #66182 (invalid_value lint: fix help text) Failed merges: r? @ghost
| ☀️ Test successful - checks-azure | 
  This was referenced Nov 8, 2019 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    merged-by-bors
  This PR was explicitly merged by bors. 
  
    rollup
  A PR which is a rollup 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Successful merges:
unsafeblocks in libcore #63793 (Have tidy ensure that we document allunsafeblocks in libcore)Failed merges:
r? @ghost