Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no merge] crater pre-expansion gating #66063

Closed
wants to merge 1 commit into from
Closed

[no merge] crater pre-expansion gating #66063

wants to merge 1 commit into from

Conversation

Mark-Simulacrum
Copy link
Member

r? @ghost

@Mark-Simulacrum
Copy link
Member Author

This reverts #66004 to get us to a point where we observed the regressions and applies #65974 to hopefully mitigate a known source of regressions. It also sets the release channel to beta.

This first try build will be the 'end' commit in our crater run, i.e., with the pre-expansion gating applied. We'll also get the start commit momentarily by building off of master with the beta commit being the only commit applied...

@bors try

@bors
Copy link
Contributor

bors commented Nov 3, 2019

⌛ Trying commit c0a8ffe622f75d9e2e124bd47797553c410ccaad with merge 8810c24b0958114d8dbb32d878444e8956fce80f...

@Mark-Simulacrum
Copy link
Member Author

@bors try

And the start commit, hopefully...

@bors
Copy link
Contributor

bors commented Nov 3, 2019

⌛ Trying commit 61fec2f with merge 5e63397...

bors added a commit that referenced this pull request Nov 3, 2019
@bors
Auto merge of #66063 - Mark-Simulacrum:crater-pre-expansion-gate, r=<…
5e63397 
…try>

[no merge] crater pre-expansion gating

r? @ghost
@bors
Copy link
Contributor

bors commented Nov 3, 2019

☀️ Try build successful - checks-azure
Build commit: 5e63397 (5e633973aa9255a88b65a39484627bb54e6044b3)

@Mark-Simulacrum
Copy link
Member Author

@craterbot run mode=check-only start=try#5e633973aa9255a88b65a39484627bb54e6044b3 end=try#8810c24b0958114d8dbb32d878444e8956fce80f cap-lints=allow

@craterbot
Copy link
Collaborator

👌 Experiment pr-66063 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 3, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 4, 2019
Closed
@craterbot
Copy link
Collaborator

🚧 Experiment pr-66063 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-66063 is completed!
📊 9 regressed and 0 fixed (77633 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 6, 2019
@Mark-Simulacrum
Copy link
Member Author

Closing this PR as we've gathered what we wanted to here, I believe. Initial assessment looks quite good (surprisingly to me, to be honest - either this was not a successful test, or no one is using unstable syntax in the wild?). I suppose we don't have that many features that touch syntax.

In any case, I'll try and followup on the original issue soon with these results.

@Mark-Simulacrum Mark-Simulacrum deleted the crater-pre-expansion-gate branch November 6, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mark-Simulacrum @bors @craterbot