Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lint callback from driver #65834

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This is leftover from a restructuring of lint registration for drivers; it should now happen via the register_lints field on Config rather than this function.

This is not used by anyone to my knowledge (including the compiler itself); it was introduced in an abandoned refactor in #65193.

This is leftover from a restructuring of lint registration for drivers;
it should now happen via the register_lints field on Config rather than
this function.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2019
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 26, 2019

📌 Commit 402a8af has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
@bors
Copy link
Contributor

bors commented Oct 26, 2019

⌛ Testing commit 402a8af with merge 41bcc6f9430e84f24a1a4699ffd2e45b070e9889...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-26T04:24:06.3944573Z do so (now or later) by using -b with the checkout command again. Example:
2019-10-26T04:24:06.3944715Z 
2019-10-26T04:24:06.3944916Z   git checkout -b <new-branch-name>
2019-10-26T04:24:06.3945120Z 
2019-10-26T04:24:06.3945528Z HEAD is now at 41bcc6f94 Auto merge of #65834 - Mark-Simulacrum:driver-clean, r=nikomatsakis
2019-10-26T04:24:06.4313384Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-10-26T04:24:06.4436906Z ==============================================================================
2019-10-26T04:24:06.4437016Z Task         : Bash
2019-10-26T04:24:06.4437093Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-10-26T04:25:40.8742733Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-10-26T04:25:40.8742854Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-10-26T04:25:40.8746009Z 
2019-10-26T04:25:40.8751449Z Failures
2019-10-26T04:25:40.8758069Z  - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-10-26T04:25:40.8758222Z  The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-10-26T04:25:41.4341517Z 
2019-10-26T04:25:41.4437869Z ##[error]Bash exited with code '1'.
2019-10-26T04:25:41.4651180Z ##[section]Starting: Upload CPU usage statistics
2019-10-26T04:25:41.4776567Z ==============================================================================
2019-10-26T04:25:41.4777082Z Task         : Bash
2019-10-26T04:25:41.4777184Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-10-26T04:25:41.7747965Z ========================== Starting Command Output ===========================
2019-10-26T04:25:41.7753477Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc /d/a/_temp/6f81ee19-9b79-46b7-b89a-076bcf39e409.sh
2019-10-26T04:25:41.8198448Z /d/a/_temp/6f81ee19-9b79-46b7-b89a-076bcf39e409.sh: line 1: aws: command not found
2019-10-26T04:25:41.8231746Z 
2019-10-26T04:25:41.8249617Z ##[error]Bash exited with code '127'.
2019-10-26T04:25:41.8322916Z ##[section]Starting: Checkout
2019-10-26T04:25:41.8429963Z ==============================================================================
2019-10-26T04:25:41.8430078Z Task         : Get sources
2019-10-26T04:25:41.8430169Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Oct 26, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2019
@JohnTitor
Copy link
Member

It's a network error.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
…omatsakis

Remove lint callback from driver

This is leftover from a restructuring of lint registration for drivers; it should now happen via the register_lints field on Config rather than this function.

This is not used by anyone to my knowledge (including the compiler itself); it was introduced in an abandoned refactor in rust-lang#65193.
Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
…omatsakis

Remove lint callback from driver

This is leftover from a restructuring of lint registration for drivers; it should now happen via the register_lints field on Config rather than this function.

This is not used by anyone to my knowledge (including the compiler itself); it was introduced in an abandoned refactor in rust-lang#65193.
Centril added a commit to Centril/rust that referenced this pull request Oct 27, 2019
…omatsakis

Remove lint callback from driver

This is leftover from a restructuring of lint registration for drivers; it should now happen via the register_lints field on Config rather than this function.

This is not used by anyone to my knowledge (including the compiler itself); it was introduced in an abandoned refactor in rust-lang#65193.
bors added a commit that referenced this pull request Oct 27, 2019
Rollup of 6 pull requests

Successful merges:

 - #65566 (Use heuristics to suggest assignment)
 - #65738 (Coherence should allow fundamental types to impl traits when they are local)
 - #65777 (Don't ICE for completely unexpandable `impl Trait` types)
 - #65834 (Remove lint callback from driver)
 - #65839 (Clean up `check_consts` now that new promotion pass is implemented)
 - #65855 (Add long error explaination for E0666)

Failed merges:

r? @ghost
@bors bors merged commit 402a8af into rust-lang:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants