Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ICE for completely unexpandable impl Trait types #65777

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Don't ICE for completely unexpandable impl Trait types #65777

merged 2 commits into from
Oct 27, 2019

Conversation

matthewjasper
Copy link
Contributor

@matthewjasper matthewjasper commented Oct 24, 2019 •
edited
Loading

Save the resolution of these types (to themselves) to the typeck tables so that they will eventually reach E0720.

closes #65561

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2019
davidtwco
davidtwco approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me after @Centril‘s comments. Should the description be changed to close #65561?

@lqd lqd mentioned this pull request Oct 25, 2019
Closed
@matthewjasper @Centril
Apply suggestions from code review
0c05ed2 
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@matthewjasper
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Oct 25, 2019

📌 Commit 0c05ed2 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2019
@bors
Copy link
Contributor

bors commented Oct 26, 2019

⌛ Testing commit 0c05ed2 with merge 3fcb193fa0911ad67787daa5e99b41e098f8c14a...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-10-26T04:21:51.0368825Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-10-26T04:21:51.0369076Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-10-26T04:21:51.0372764Z 
2019-10-26T04:21:51.0377724Z Failures
2019-10-26T04:21:51.0383380Z  - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-10-26T04:21:51.0383699Z  The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-10-26T04:21:51.4993028Z 
2019-10-26T04:21:51.5083704Z ##[error]Bash exited with code '1'.
2019-10-26T04:21:51.5323919Z ##[section]Starting: Upload CPU usage statistics
2019-10-26T04:21:51.5437491Z ==============================================================================
2019-10-26T04:21:51.5437769Z Task         : Bash
2019-10-26T04:21:51.5437872Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-10-26T04:21:51.8471387Z ========================== Starting Command Output ===========================
2019-10-26T04:21:51.8484474Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc /d/a/_temp/c21719a1-1431-4e0a-87b5-792353b371ea.sh
2019-10-26T04:21:51.8887027Z /d/a/_temp/c21719a1-1431-4e0a-87b5-792353b371ea.sh: line 1: aws: command not found
2019-10-26T04:21:51.8919375Z 
2019-10-26T04:21:51.8940640Z ##[error]Bash exited with code '127'.
2019-10-26T04:21:51.9019850Z ##[section]Starting: Checkout
2019-10-26T04:21:51.9123350Z ==============================================================================
2019-10-26T04:21:51.9123475Z Task         : Get sources
2019-10-26T04:21:51.9123578Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Oct 26, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2019
@matthewjasper
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
@Centril
Rollup merge of rust-lang#65777 - matthewjasper:allow-impl-trait-expa…
0498da3 
…nsion, r=davidtwco

Don't ICE for completely unexpandable `impl Trait` types

Save the resolution of these types (to themselves) to the typeck tables so that they will eventually reach E0720.

closes rust-lang#65561
@Centril Centril mentioned this pull request Oct 26, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
@Centril
Rollup merge of rust-lang#65777 - matthewjasper:allow-impl-trait-expa…
8a5f08f 
…nsion, r=davidtwco

Don't ICE for completely unexpandable `impl Trait` types

Save the resolution of these types (to themselves) to the typeck tables so that they will eventually reach E0720.

closes rust-lang#65561
@Centril Centril mentioned this pull request Oct 26, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 27, 2019
@Centril
Rollup merge of rust-lang#65777 - matthewjasper:allow-impl-trait-expa…
5406f7a 
…nsion, r=davidtwco

Don't ICE for completely unexpandable `impl Trait` types

Save the resolution of these types (to themselves) to the typeck tables so that they will eventually reach E0720.

closes rust-lang#65561
@Centril Centril mentioned this pull request Oct 27, 2019
Merged
bors added a commit that referenced this pull request Oct 27, 2019
@bors
Auto merge of #65869 - Centril:rollup-bzlo74f, r=Centril
95f437b 
Rollup of 6 pull requests

Successful merges:

 - #65566 (Use heuristics to suggest assignment)
 - #65738 (Coherence should allow fundamental types to impl traits when they are local)
 - #65777 (Don't ICE for completely unexpandable `impl Trait` types)
 - #65834 (Remove lint callback from driver)
 - #65839 (Clean up `check_consts` now that new promotion pass is implemented)
 - #65855 (Add long error explaination for E0666)

Failed merges:

r? @ghost
@bors bors merged commit 0c05ed2 into rust-lang:master Oct 27, 2019
@matthewjasper matthewjasper deleted the allow-impl-trait-expansion branch October 28, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE when using 'impl Trait' with an infinity recursive function
5 participants
@matthewjasper @rust-highfive @bors @Centril @davidtwco